[Mac] Fix ClassCastException when selecting a color in FontDialog #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Phillipus
commented
Feb 8, 2025
Phillipus
commented
- See [Mac] ClassCastException when selecting a color in FontDialog #1814
Contributor
Test Results 509 files ±0 509 suites ±0 9m 14s ⏱️ +11s For more details on these failures, see this check. Results for commit 8d360f9. ± Comparison against base commit 1f67f33. ♻️ This comment has been updated with latest results. |
Phillipus
changed the title
Phillipus
force-pushed
the
macfontdialogfix
branch
2 times, most recently
from
d06d41b to
7429064
Compare
Member
|
I tried this PR, and after applying the patch, I no longer see the ClassCastException. This looks good to me functionally. |
Phillipus
force-pushed
the
macfontdialogfix
branch
from
7429064 to
c94f156
Compare
Phillipus
force-pushed
the
macfontdialogfix
branch
from
c94f156 to
d742aa6
Compare
Contributor
Author
Can this be merged now? |
merks
reviewed
Mar 13, 2025
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
- See eclipse-platform#1814 - Also use Java 17 instanceof pattern matching in this code block
Phillipus
force-pushed
the
macfontdialogfix
branch
from
d742aa6 to
8d360f9
Compare
merks
approved these changes
Mar 13, 2025
Contributor
|
It looks like unrelated browser tests failed on Windows. |
Contributor
Author
|
Thanks for the merge. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.