From cabae9447ab27c9a608a3498cedfbf5fe866dc30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0=BD=D0=B4=D1=8A?= =?UTF-8?q?=D1=80=20=D0=9A=D1=83=D1=80=D1=82=D0=B0=D0=BA=D0=BE=D0=B2?= Date: Thu, 27 Mar 2025 12:53:26 +0200 Subject: [PATCH] Reenable wrongly disabled Browser tests In https://github.com/eclipse-platform/eclipse.platform.swt/commit/50da5ad8523b8c29ef79c494435c71f7e452d025 logic to disable tests was changed in a wrong way. Enable these tests unconditionally now that the prereqs are mandated. --- .../tests/junit/Test_org_eclipse_swt_browser_Browser.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java index dd42f9b26fc..24de43fb544 100644 --- a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java +++ b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java @@ -131,8 +131,6 @@ public class Test_org_eclipse_swt_browser_Browser extends Test_org_eclipse_swt_w Browser browser; boolean isEdge = false; - static int[] webkitGtkVersionInts = new int[3]; - /** Accumiliate logs, print only if test case fails. Cleared for each test case. */ StringBuilder testLog; private void testLogAppend(String msg) { @@ -438,9 +436,6 @@ public void test_evalute_Cookies () { @Test public void test_ClearAllSessionCookies () { - // clearSessions will only work for Webkit2 when >= 2.16 - assumeTrue(webkitGtkVersionInts[1] >= 16); - final AtomicBoolean loaded = new AtomicBoolean(false); browser.addProgressListener(ProgressListener.completedAdapter(event -> loaded.set(true))); @@ -470,8 +465,6 @@ public void test_ClearAllSessionCookies () { @Test public void test_get_set_Cookies() { - // set/get cookies will only work for WebKit2.20+ - assumeTrue(webkitGtkVersionInts[1] >= 20); final AtomicBoolean loaded = new AtomicBoolean(false); browser.addProgressListener(ProgressListener.completedAdapter(event -> loaded.set(true)));