Skip to content

Reenable wrongly disabled Browser tests #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Mar 27, 2025
Merged

Reenable wrongly disabled Browser tests #1953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ...t.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,6 @@ public class Test_org_eclipse_swt_browser_Browser extends Test_org_eclipse_swt_w
Browser browser;
boolean isEdge = false;

static int[] webkitGtkVersionInts = new int[3];

/** Accumiliate logs, print only if test case fails. Cleared for each test case. */
StringBuilder testLog;
private void testLogAppend(String msg) {
Expand Down Expand Up @@ -438,9 +436,6 @@ public void test_evalute_Cookies () {

@Test
public void test_ClearAllSessionCookies () {
// clearSessions will only work for Webkit2 when >= 2.16
assumeTrue(webkitGtkVersionInts[1] >= 16);

final AtomicBoolean loaded = new AtomicBoolean(false);
browser.addProgressListener(ProgressListener.completedAdapter(event -> loaded.set(true)));

Expand Down Expand Up @@ -470,8 +465,6 @@ public void test_ClearAllSessionCookies () {

@Test
public void test_get_set_Cookies() {
// set/get cookies will only work for WebKit2.20+
assumeTrue(webkitGtkVersionInts[1] >= 20);
final AtomicBoolean loaded = new AtomicBoolean(false);
browser.addProgressListener(ProgressListener.completedAdapter(event -> loaded.set(true)));

Expand Down
Loading