[win32] Utilize temporary image handles #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoch-yatta
force-pushed
the
win32-image-utilize-temporary-handles
branch
2 times, most recently
from
57720db to
644926a
Compare
Contributor
Test Results 539 files + 373 539 suites +373 32m 27s ⏱️ + 23m 10s For more details on these failures, see this check. Results for commit b2c3a84. ± Comparison against base commit 13f7cc0. This pull request removes 37 and adds 37 tests. Note that renamed tests count towards both.This pull request removes 3 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
fedejeanne
approved these changes
May 6, 2025
Member
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
The code looks OK and I saw no regressions when running the Runtime Workspace Eclipse Application. I only have some minor comments regarding coding style.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
HeikoKlare
reviewed
May 6, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
In general, the change looks fine. In particular the usage of deviceZoom for the temporary handle (if necessary) makes sense to me. I only have question regarding the implementation of the deprecated methods, most importantly the getImageDataAtCurrentZoom() one.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
win32-image-utilize-temporary-handles
branch
from
644926a to
dd5a6a2
Compare
This commit adapts all places, where operation where executed with OS handles created for a specific zoom that could use any zoom. Therefor now any existing handle is used or, if none exists yet, a temporary handle is created and destroyed afterwards.
HeikoKlare
force-pushed
the
win32-image-utilize-temporary-handles
branch
from
dd5a6a2 to
b2c3a84
Compare
HeikoKlare
approved these changes
May 6, 2025
Contributor
|
Failing test is unrelated: #1843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts all places, where operation where executed with OS handles created for a specific zoom that could use any zoom. Therefor now any existing handle is used or, if none exists yet, a temporary handle is created and destroyed afterwards.