Skip to content

[win32] Fix double buffer paint with ImageGcDrawer #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

[win32] Fix double buffer paint with ImageGcDrawer #2122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1691,7 +1691,7 @@ private ImageHandle init(ImageData i, int zoom) {
*/
@Override
public long internal_new_GC (GCData data) {
return configureGC(data, 100);
return this.imageProvider.configureGCData(data);
}

private long configureGC(GCData data, int zoom) {
Expand Down Expand Up @@ -1854,6 +1854,10 @@ private abstract class AbstractImageProviderWrapper {

protected abstract Rectangle getBounds(int zoom);

protected long configureGCData(GCData data) {
return configureGC(data, 100);
}

public Collection<Integer> getPreservedZoomLevels() {
return Collections.emptySet();
}
Expand Down Expand Up @@ -2480,6 +2484,7 @@ private class ImageGcDrawerWrapper extends DynamicImageProviderWrapper {
private ImageGcDrawer drawer;
private int width;
private int height;
private int currentZoom = 100;

ImageGcDrawerWrapper(ImageGcDrawer imageGcDrawer, int width, int height) {
checkProvider(imageGcDrawer, ImageGcDrawer.class);
Expand All @@ -2494,13 +2499,19 @@ protected Rectangle getBounds(int zoom) {
return DPIUtil.scaleBounds(rectangle, zoom, 100);
}

@Override
protected long configureGCData(GCData data) {
return configureGC(data, currentZoom);
}

@Override
ImageData newImageData(int zoom) {
return getImageMetadata(zoom).getImageData();
}

@Override
protected ImageHandle newImageHandle(int zoom) {
currentZoom = zoom;
int gcStyle = drawer.getGcStyle();
Image image;
if ((gcStyle & SWT.TRANSPARENT) != 0) {
Expand Down
Loading