Skip to content

Issue #603: [Win32] Shell-TaskItem: overlay text remains after the shell is closed #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2023
Merged

Issue #603: [Win32] Shell-TaskItem: overlay text remains after the shell is closed #679

merged 3 commits into from
Jun 20, 2023

Conversation

@SyntevoAlex
Copy link
Member

@SyntevoAlex SyntevoAlex commented May 22, 2023

Fixes #603

@SyntevoAlex SyntevoAlex force-pushed the z_alexandr.miloslavskiy/#0581_SWT_Issue0603_WrongTaskBarOverlays branch from b1604e9 to f95b6b3 Compare May 22, 2023 01:26
@SyntevoAlex SyntevoAlex mentioned this pull request May 22, 2023
Closed
@SyntevoAlex
Copy link
Member Author

SyntevoAlex commented May 22, 2023

I intend to merge this around 2023-05-24 if there are no objections.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023 •
edited
Loading

Test Results

     299 files  +   115       299 suites  +115   7m 7s ⏱️ + 2m 58s
  4 089 tests +     34    4 081 ✔️ +     32    8 💤 +  2  0 ❌ ±0 
12 179 runs  +5 015  12 108 ✔️ +4 962  71 💤 +53  0 ❌ ±0 

Results for commit 87fe7bc. ± Comparison against base commit 96b1f8d.

♻️ This comment has been updated with latest results.

@iloveeclipse
Copy link
Member

iloveeclipse commented May 22, 2023

I intend to merge this around 2023-05-24 if there are no objections.

Currently we are working towards 4.28 RC1.
If this is not a recent regression or fixes an urgently needed bug, I would better postpone the fix to 4.29 M1.

Note: if you are not subscribed to https://accounts.eclipse.org/mailing-list/platform-dev, please do. There are reminders sent before/after each phase, like https://www.eclipse.org/lists/platform-dev/msg03811.html and https://www.eclipse.org/lists/platform-dev/msg03817.html

@SyntevoAlex
Copy link
Member Author

SyntevoAlex commented May 22, 2023

Sure, I will postpone it.
I am subscribed, was going to double check it before the merge.
Thanks for reminding!

@vogella
Copy link
Contributor

vogella commented May 22, 2023

FYI - Typically we have an automated check to report this, see eclipse-platform/eclipse.platform.releng.aggregator#1079

@iloveeclipse
Copy link
Member

iloveeclipse commented May 22, 2023

FYI - Typically we have an automated check to report this, see eclipse-platform/eclipse.platform.releng.aggregator#1079

Calendar was updated, and the check fails now (I've retriggered check manually).

@deepika-u
Copy link
Contributor

deepika-u commented May 23, 2023

@SyntevoAlex

With the patch looks like issue is fixed, not seeing overlay text "abc" when the window with label "With taskitem" is closed.

I have checked on below environment
Eclipse SDK
Version: 2023-06 (4.28)
Build id: I20230522-1800
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Eclipse Adoptium
Java runtime version: 20+36
Java version: 20

@SyntevoAlex
Copy link
Member Author

SyntevoAlex commented May 23, 2023

Thanks for testing!

@deepika-u
Copy link
Contributor

deepika-u commented Jun 14, 2023

Thanks for testing!

My vote goes for the fix.

@SyntevoAlex @jukzi
Issue eclipse-platform#603: Test snippet
59994ff 
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
@SyntevoAlex @jukzi
Issue eclipse-platform#603: Don't call ITaskbarList3 early
23dc699 
MSDN for 'ITaskbarList3' says:
  TaskbarButtonCreated ... message must be received by your application
  before it calls any ITaskbarList3 method

Do exactly this, don't call any methods until the button is created.

This doesn't seem to fix any currently known problems, but still the
right thing to do.

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
@SyntevoAlex @jukzi
Issue eclipse-platform#603: [win32] Windows TaskBar shows wrong overl…
87fe7bc 
…ay after closing related Shell

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
@jukzi jukzi force-pushed the z_alexandr.miloslavskiy/#0581_SWT_Issue0603_WrongTaskBarOverlays branch from f95b6b3 to 87fe7bc Compare June 15, 2023 10:23
@SyntevoAlex SyntevoAlex merged commit ec89772 into eclipse-platform:master Jun 20, 2023
@SyntevoAlex
Copy link
Member Author

SyntevoAlex commented Jun 20, 2023

In master now. Sorry for being slow, was on vacation.

@SyntevoAlex SyntevoAlex deleted the z_alexandr.miloslavskiy/#0581_SWT_Issue0603_WrongTaskBarOverlays branch June 21, 2023 13:03
@deepika-u
Copy link
Contributor

deepika-u commented Jul 4, 2023

Issue is verified, not seeing overlay text "abc" when the window with label "With taskitem" is closed.

I have checked on below environment
Eclipse SDK
Version: 2023-09 (4.29)
Build id: I20230703-1800
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Eclipse Adoptium
Java runtime version: 20+36
Java version: 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niraj-modi niraj-modi Awaiting requested review from niraj-modi

@iloveeclipse iloveeclipse Awaiting requested review from iloveeclipse

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Win32] Shell-TaskItem: overlay text remains after the shell is closed (Windows 11)

4 participants

@SyntevoAlex @iloveeclipse @vogella @deepika-u