Skip to content

Use DS annotations instead of handcrafted XML #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use DS annotations instead of handcrafted XML #2135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bundles/org.eclipse.search/.project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>org.eclipse.pde.ds.core.builder</name>
<arguments>
</arguments>
</buildCommand>
</buildSpec>
<natures>
<nature>org.eclipse.jdt.core.javanature</nature>
Expand Down
7 changes: 7 additions & 0 deletions bundles/org.eclipse.search/.settings/org.eclipse.pde.ds.annotations.prefs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
dsVersion=V1_4
eclipse.preferences.version=1
enabled=true
generateBundleActivationPolicyLazy=true
path=OSGI-INF
validationErrorLevel=error
validationErrorLevel.missingImplicitUnbindMethod=error
2 changes: 1 addition & 1 deletion bundles/org.eclipse.search/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ Require-Bundle:
org.eclipse.ltk.core.refactoring;bundle-version="[3.5.0,4.0.0)",
org.eclipse.ltk.ui.refactoring;bundle-version="[3.5.0,4.0.0)",
org.eclipse.search.core;bundle-version="[3.16.0,4.0.0)";visibility:=reexport
Service-Component: OSGI-INF/org.eclipse.search.ui.dirtyEditorSearchParticipant.xml
Bundle-RequiredExecutionEnvironment: JavaSE-17
Automatic-Module-Name: org.eclipse.search
Service-Component: OSGI-INF/*.xml
8 changes: 0 additions & 8 deletions bundles/org.eclipse.search/OSGI-INF/dirtyEditorService.xml
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions ...eclipse.search/search/org/eclipse/search/internal/ui/text/DirtyFileSearchParticipant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
import java.util.HashMap;
import java.util.Map;

import org.osgi.service.component.annotations.Component;

import org.eclipse.core.resources.IFile;

import org.eclipse.core.filebuffers.FileBuffers;
Expand All @@ -38,6 +40,7 @@

import org.eclipse.search.internal.core.text.DirtyFileProvider;

@Component(service = DirtyFileProvider.class, name = "org.eclipse.search.ui.dirtyEditorSearchParticipant", property = "weight:Integer=100")
public class DirtyFileSearchParticipant implements DirtyFileProvider {

@Override
Expand Down