FindReplaceOverlay: update position and size while not visible #2478 #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…e-platform#2478 When changing position and/or size of the editor of a FindReplaceOverlay while it is hidden, e.g., because another editor in the same editor stack is active, the position and size of the overlay is not updated accordingly. Thus, when making the editor of that overlay active again, its position relative to the editor and size is still the same as before another editor was set active, i.e., it is usually wrong. With this change, the size and position of an overlay is always updated upon resize operations of the target editor, even if the editor is not visible. Fixes eclipse-platform#2478
HeikoKlare
force-pushed
the
issue-2478
branch
from
e6731eb to
818c920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing position and/or size of the editor of a FindReplaceOverlay while it is hidden, e.g., because another editor in the same editor stack is active, the position and size of the overlay is not updated accordingly. Thus, when making the editor of that overlay active again, its position relative to the editor and size is still the same as before another editor was set active, i.e., it is usually wrong.
With this change, the size and position of an overlay is always updated upon resize operations of the target editor, even if the editor is not visible.
Fixes #2478