Fix IllegalArgumentException when styling the sticky lines #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the sticky lines are limited by the settings, the not visible sticky lines should not be styled. Fixes eclipse-platform#2496
iloveeclipse
approved these changes
Nov 5, 2024
Member
iloveeclipse
left a comment
iloveeclipse
left a comment
There was a problem hiding this comment.
I have no time for an in-depth review, and I don't know the code at all.
I've verified my case works now without errors, thanks.
Contributor
Christopher-Hermann
merged commit 3fd04b3
into
eclipse-platform:master
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the sticky lines are limited by the settings, the not visible sticky lines should not be styled.
Fixes #2496