Skip to content

Conversation

@reedenb
Copy link
Contributor

@reedenb reedenb commented Jan 28, 2025

  • Add preferences import and export help contexts to IWorkbenchHelpContextIds.java
  • Register missing help contexts for WizardPreferencesExportPage1.java and WizardPreferencesImportPage1.java to the help system.

Fixes #2759

- Add preferences import and export help contexts to IWorkbenchHelpContextIds.java
- Register missing help contexts for WizardPreferencesExportPage1.java and WizardPreferencesImportPage1.java to the help system.

Fixes eclipse-platform#2759
@github-actions
Copy link
Contributor

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 30m 42s ⏱️ - 5m 23s
 7 717 tests ±0   7 488 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 312 runs  ±0  23 562 ✅  - 1  749 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 5d879f9. ± Comparison against base commit 92e290e.

@reedenb
Copy link
Contributor Author

reedenb commented Feb 3, 2025

@fedejeanne Does this look okay?
Let me know if any changes/addition are required.

@deepika-u
Copy link
Contributor

Hi, I tried on the below version and still help doesnt open in "Import Preferences". Can you please recheck on the same.
image

I am on the below environment, Sorry if i missed to reply you last time.
Eclipse SDK
Version: 2025-03 (4.35)
Build id: I20250203-1800
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Eclipse Adoptium
Java runtime version: 23.0.1+11
Java version: 23.0.1

@reedenb
Copy link
Contributor Author

reedenb commented Feb 4, 2025

@deepika-u how are you testing the applied pr? Doesn't look like you're running a new product from the ide.

@deepika-u
Copy link
Contributor

@deepika-u how are you testing the applied pr? Doesn't look like you're running a new product from the ide.

You are right, after applying the pr, i took a child workspace and see that your fix works for me.
image

Thanks for correcting me.

@reedenb
Copy link
Contributor Author

reedenb commented Feb 4, 2025

@deepika-u happy to help :)

@BeckerWdf BeckerWdf added this to the 4.35 M3 milestone Feb 4, 2025
@BeckerWdf
Copy link
Member

So this is read to merge?

@reedenb
Copy link
Contributor Author

reedenb commented Feb 4, 2025

@BeckerWdf there's 1 test failure in Test Results specific to MacOS. I'm assuming it's flaky.

I think this is ready to merge.

@BeckerWdf BeckerWdf merged commit 0552cdc into eclipse-platform:master Feb 4, 2025
7 checks passed
@BeckerWdf
Copy link
Member

Thanks @reedenb for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Help not shown in "Import preferences" dialog

3 participants