Skip to content

Help not shown in "Import preferences" dialog #2759 #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Help not shown in "Import preferences" dialog #2759 #2761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d879f9
Help not shown in "Import preferences" dialog #2759
reedenb Jan 28, 2025
fe84c1f
Merge branch 'master' of https://github.com/eclipse-platform/eclipse.…
reedenb Feb 1, 2025
119b6fc
Correct helpcontext for export page
reedenb Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/IWorkbenchHelpContextIds.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,5 +249,10 @@ public interface IWorkbenchHelpContextIds {
String WORKING_SET_EDIT_WIZARD = PREFIX + "working_set_edit_wizard_context"; //$NON-NLS-1$

String CAPABILITY_PREFERENCE_PAGE = PREFIX + "capabilities_preference_page_context"; //$NON-NLS-1$

String TOGGLE_COOLBAR_ACTION = PREFIX + "toggle_coolbar_action"; //$NON-NLS-1$

String PREFERENCES_IMPORT_WIZARD_PAGE = PREFIX + "preferences_import_wizard_page"; //$NON-NLS-1$

String PREFERENCES_EXPORT_WIZARD_PAGE = PREFIX + "preferences_export_wizard_page"; //$NON-NLS-1$
}
8 changes: 8 additions & 0 deletions ...h/eclipseui/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesExportPage1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import org.eclipse.swt.SWT;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
import org.eclipse.ui.internal.WorkbenchPlugin;
import org.eclipse.ui.internal.preferences.PreferenceTransferElement;

Expand Down Expand Up @@ -54,6 +56,12 @@ public WizardPreferencesExportPage1() {
this(PREFERENCESEXPORTPAGE1);
}

@Override
public void createControl(Composite composite) {
super.createControl(composite);
PlatformUI.setHelp(composite, IWorkbenchHelpContextIds.PREFERENCES_EXPORT_WIZARD_PAGE);
}

protected String getOutputSuffix() {
return ".epf"; //$NON-NLS-1$
}
Expand Down
8 changes: 8 additions & 0 deletions ...h/eclipseui/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesImportPage1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import org.eclipse.swt.SWT;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Event;
import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
import org.eclipse.ui.internal.WorkbenchPlugin;
import org.eclipse.ui.internal.preferences.PreferenceTransferElement;

Expand Down Expand Up @@ -52,6 +54,12 @@ public WizardPreferencesImportPage1() {
this("preferencesImportPage1");//$NON-NLS-1$
}

@Override
public void createControl(Composite composite) {
super.createControl(composite);
PlatformUI.setHelp(composite, IWorkbenchHelpContextIds.PREFERENCES_IMPORT_WIZARD_PAGE);
}

@Override
protected String getAllButtonText() {
return PreferencesMessages.WizardPreferencesImportPage1_all;
Expand Down