Add Eclipse logo SVGs to build.properties #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recently added Eclispe logo SVGs have not been added to the build.properties to make the deployed binary bundle also contain them. This change adds them accordingly.
Contributor
fedejeanne
approved these changes
Jul 21, 2025
Member
|
Why do we need 3 svgs ? |
Contributor
Author
The same reason why we had 3 PNGs: the icon is required at different sizes (independent from HiDPI support with zoomed versions). Since there is no API to load an image (including an SVG) at a specific size yet (we are working on extending on that), images need to be provided in the size in which they are required, which for the Eclipse icon seem to be 16x16, 32x32 and 48x48 versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added Eclispe logo SVGs have not been added to the build.properties to make the deployed binary bundle also contain them. This change adds them accordingly.
Fixes eclipse-platform/eclipse.platform.swt#2327