Skip to content

Fix: allow multiple dependencies #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

Fix: allow multiple dependencies #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45633cd
Fix: allow multiple dependencies
AlexanderLanin Nov 11, 2025
1d0beae
upgrade version
AlexanderLanin Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

module(
name = "score_docs_as_code",
version = "2.0.0",
version = "2.0.1",
compatibility_level = 2,
)

Expand Down
7 changes: 4 additions & 3 deletions src/extensions/score_metamodel/external_needs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,6 @@ def add_external_needs_json(e: ExternalNeedsSource, config: Config):
)
# Attempt to continue, exit code will be non-zero after a logged error anyway.
return
# this sets the default value - required for the needs-config-writer
# setting 'needscfg_exclude_defaults = True' to see the diff
config.needs_external_needs = []
assert isinstance(config.needs_external_needs, list) # pyright: ignore[reportUnknownMemberType]
config.needs_external_needs.append( # pyright: ignore[reportUnknownMemberType]
{
Expand Down Expand Up @@ -217,6 +214,10 @@ def connect_external_needs(app: Sphinx, config: Config):

external_needs = get_external_needs_source(app.config.external_needs_source)

# this sets the default value - required for the needs-config-writer
# setting 'needscfg_exclude_defaults = True' to see the diff
config.needs_external_needs = []

for e in external_needs:
assert not e.path_to_target # path_to_target is always empty

Expand Down
Loading