Canonical creation tools from contextual toolbar have no icons

[AxelRICHARD]

• I have checked that this bug has not yet been reported by someone else
• I have checked that this bug appears on Chrome
• I have specified the version :

• 2022.11.13

• I have specified my environment :

• my computer: macOS

Screenshots

Steps to reproduce

1. Your SiriusWeb instance should not have the Domain package, only View package
2. Create a View model
3. Create a Diagram Description that applies on an existing class from a metamodel (not from a Domain)
4. Create a valid Node that applies on an existing class from the same metamodel
5. Create a Diagram from the Diagram Description
6. Click on the diagram background: a creation tool is provided by default, based on the Diagram Description and the View.

Expected behavior

The canonical creation tool provided by default should have an icon, ideally the icon associated to the EClass/DomainClass.

Actual behavior

The canonical creation tool provided by default doesn't have any icon.

Help resources

The problem comes from ViewDiagramDescriptionConverter.java. String NODE_CREATION_TOOL_ICON = "/img/Entity.svg"; & EDGE_CREATION_TOOL_ICON = "/img/Relation.svg"; refer to SVG coming from Domain package.

Solution proposed

1. String NODE_CREATION_TOOL_ICON = "/img/Entity.svg"; & EDGE_CREATION_TOOL_ICON = "/img/Relation.svg"; should refer to SVG from View package.

2. Canonical creation tools should try to get icons associated to the EClass/DomainClass and fallback to a default icon on failure.