Direct edit triggered by directly starting to type loses the first character

[pcdavid]

Steps to reproduce:

1. Open a Topography diagram on the Robot Flow sample
2. Select a node, say "Radar"
3. Start typing the string "renamed"
4. The direct edit behavior is triggered but the initial letter r was lost
5. Validate the edit
6. The final name is "enamed"

screencast-2021-04-22_17.33.51.mp4

[pcdavid]

From what I see, it seems the code is consistent with the behavior described. What's strange is more that it seems to work under macOS...

AFAICT, the process is:

• In DependencyInjection.ts we setup a KeyListener which does something like:

if (event.code === 'F2') {
  return [{ kind: EditLabelAction.KIND, element }];
} else if (validFirstInputChar(event)) {
  return [{ kind: EditLabelAction.KIND, element }];
}

i.e. in both case we simply trigger Sprotty's edit label action, but without passing it any info about the event/char that triggered it.

• The action is handled in WebSocketDiagramServer.tsx by dispatching a new EditLabelAction(label.id) to Sprotty, which ends up calling Sprotty's EditLabelUI. This creates a new input element in the DOM to accept the new text, and during its initialization, onBeforeShow it calls applyTextContents which does this.inputElement.value = this.label.text;, i.e. it initializes the contents of the new input element with the current text of the label.

This seems consistent with the current behavior, except for 2 issues:

• under Safari, the new input seems to be initialized with the first char entered to trigger the label edition. I don't understand how (and don't have access to a mac to test further).
• if I pass the firstChar to the action we send to WebSocketDiagramServer, and there update the label's text value before calling Sprotty's EditLabelUI, the new text label is not the one used to initialize the input either.

[pcdavid]

Apparently I was wrong and it never worked even under macOS/Safari. I misinterpreted previous messages.