Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implausibleRoutes.py: unsorted input and vehtype missing #12069

Closed
ambuehll opened this issue Nov 17, 2022 · 7 comments
Closed

implausibleRoutes.py: unsorted input and vehtype missing #12069

ambuehll opened this issue Nov 17, 2022 · 7 comments

Comments

@ambuehll
Copy link

I am currently facing multiple issues with implausibleRoutes.py.
I use the script to check whether the routes from a sumo sim are realistic. Therefore, I test it on standard route-output from a sumo micro/meso sim.
The issues below are caused by calling duarouter inside implausibleRoutes.py

  1. when I have veh_types in the route file, I have to copy paste the vType_distribution into the route file. Otherwise I get e.g. Error: The vehicle type 'car' for vehicle 'F38545' is not known.
    Copying the vtype dist is not a problem, but not an elegant work-around
  2. my routes file is not sorted. So it throws another error telling me the input is not sorted.

Setting unsorted-input in the duarouter call would solve 2.

Thanks

Lukas

@namdre
Copy link
Contributor

namdre commented Nov 17, 2022

Adding two options to the script that can be passed to duarouter (--additional-files and --unsorted-input) should easily solve this. Would you care to do this yourself and add a pull request? Alternatively, could you be so kind and prepare a minimal input test case. Then I could quickly add a fix myself.

@ambuehll
Copy link
Author

aminissn volunteered 🥇

@behrisch
Copy link
Contributor

There is still a test missing, I suppose?

@behrisch
Copy link
Contributor

@aminissn @ambuehll Do you find the time to add a test here?

@ambuehll
Copy link
Author

ambuehll commented Dec 2, 2022

Unfortunately not right now. Sorry. I can try to look into it next month. Maybe @aminissn :)

@aminissn
Copy link
Contributor

aminissn commented Dec 6, 2022

@behrisch I hope this fulfills the requirements as a minimal test scenario:
test_implausibleRoutes.zip

@behrisch
Copy link
Contributor

behrisch commented Dec 6, 2022

4 MB of data is more than what I would call minimal ;-) Nevermind I added a test.

@behrisch behrisch closed this as completed Dec 6, 2022
behrisch added a commit that referenced this issue Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants