Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad default settings when loading a 2D viewport in OSG view #12348

Closed
m-kro opened this issue Dec 23, 2022 · 1 comment
Closed

Bad default settings when loading a 2D viewport in OSG view #12348

m-kro opened this issue Dec 23, 2022 · 1 comment
Assignees
@m-kro
Labels
a:sumo-gui bug OSG Label for tickets relatives to OSG
Milestone
1.16.0

Comments

@m-kro
Copy link
Contributor

m-kro commented Dec 23, 2022

Currently, default values for camera and "lookAt" position are (-1;-1;-1). As there is no check whether "lookAt" and camera Z coordinate are actually overwritten, the resulting view is different from bird position if only X/Y coordinates are present in the view settings. Instead, Z coordinate should be checked and coordinates prepared for bird view if no Z value is found.
@m-kro m-kro added a:sumo-gui bug OSG Label for tickets relatives to OSG labels Dec 23, 2022
@m-kro m-kro added this to the 1.16.0 milestone Dec 23, 2022
@m-kro m-kro self-assigned this Dec 23, 2022
@m-kro m-kro closed this as completed in f295146 Dec 23, 2022
namdre added a commit that referenced this issue Dec 24, 2022
@namdre
Revert "bird view in OSG when loading 2D viewport fix #12348" because…
cbd1b6c 
… it breaks

tests and I don't want broken tests over christmas.

This reverts commit f295146.
@namdre
Copy link
Contributor

namdre commented Dec 24, 2022

needs a little rework to preserve written gui settings for the non-3D case.

@namdre namdre reopened this Dec 24, 2022
m-kro added a commit that referenced this issue Jan 2, 2023
@m-kro
bird view in OSG when loading 2D viewport with silent attribute check #…
cc99c02 
…12348

Signed-off-by: m-kro <m.barthauer@t-online.de>
@behrisch behrisch closed this as completed Jan 3, 2023
m-kro added a commit that referenced this issue Jan 17, 2023
@m-kro
actually set center pos during recentering in OSG ref #12348
bff61ce 
Signed-off-by: m-kro <m.barthauer@t-online.de>
m-kro added a commit that referenced this issue Jan 17, 2023
@m-kro
invert initial value of Z coord marker ref #12348
05389a2 
Signed-off-by: m-kro <m.barthauer@t-online.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-kro m-kro

Labels
a:sumo-gui bug OSG Label for tickets relatives to OSG
Projects
None yet
Milestone
1.16.0
Development

No branches or pull requests
3 participants
@behrisch @namdre @m-kro