From 2e4ac028b10e45dc2130c6f319b4c5a95e13e01c Mon Sep 17 00:00:00 2001 From: Marco Miller Date: Tue, 20 Dec 2022 16:05:45 -0500 Subject: [PATCH] callstack: Fix CallStackAnalysis format in Eclipse Change-Id: I70f8f3c84f470e5391160827f1a96fd6bc53c50f Signed-off-by: Marco Miller Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/197777 Tested-by: Trace Compass Bot Tested-by: Matthew Khouzam Reviewed-by: Matthew Khouzam --- .../core/callstack/CallStackAnalysis.java | 38 ++++++++++--------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/analysis/org.eclipse.tracecompass.analysis.profiling.core/src/org/eclipse/tracecompass/analysis/profiling/core/callstack/CallStackAnalysis.java b/analysis/org.eclipse.tracecompass.analysis.profiling.core/src/org/eclipse/tracecompass/analysis/profiling/core/callstack/CallStackAnalysis.java index d0b36b0cf6..be61877fe9 100644 --- a/analysis/org.eclipse.tracecompass.analysis.profiling.core/src/org/eclipse/tracecompass/analysis/profiling/core/callstack/CallStackAnalysis.java +++ b/analysis/org.eclipse.tracecompass.analysis.profiling.core/src/org/eclipse/tracecompass/analysis/profiling/core/callstack/CallStackAnalysis.java @@ -47,8 +47,11 @@ */ public abstract class CallStackAnalysis extends TmfStateSystemAnalysisModule implements IFlameChartProvider, ICallGraphProvider { - /** CallStack stack-attribute - * @since 1.1*/ + /** + * CallStack stack-attribute + * + * @since 1.1 + */ public static final String CALL_STACK = "CallStack"; //$NON-NLS-1$ private static final String[] DEFAULT_PROCESSES_PATTERN = new String[] { CallStackStateProvider.PROCESSES, "*" }; //$NON-NLS-1$ @@ -93,9 +96,10 @@ public String[] getProcessesPattern() { } /** - * Resolve the device ID if applicable. A device is the hardware context the trace is running - * on. An example would be CPU, GPU, DSP or even FPGA. This could allow device centric analyses - * such as the Callsite analysis to enrich the view. + * Resolve the device ID if applicable. A device is the hardware context the + * trace is running on. An example would be CPU, GPU, DSP or even FPGA. This + * could allow device centric analyses such as the Callsite analysis to + * enrich the view. * * @param quark * quark of the state system to query @@ -108,7 +112,6 @@ public String[] getProcessesPattern() { return null; } - /** * Resolve the device type if applicable. A device is the hardware context * the trace is running on. An example would be CPU, GPU, DSP or even FPGA. @@ -231,8 +234,8 @@ public void dispose() { } /** - * Get the callstack host ID resolver for this instrumented series. The default - * is to use the host name of the trace. + * Get the callstack host ID resolver for this instrumented series. The + * default is to use the host name of the trace. * * @param trace * The trace this analysis is run on @@ -244,8 +247,8 @@ protected TraceHostIdResolver getCallStackHostResolver(ITmfTrace trace) { } /** - * Get the callstack TID resolver for this instrumented series. The default is - * to use the name of the second attribute as the thread ID. + * Get the callstack TID resolver for this instrumented series. The default + * is to use the name of the second attribute as the thread ID. * * @return The thread ID resolver * @since 1.1 @@ -317,19 +320,18 @@ public ICallGraphProvider getCallGraph() { } /** - * Set whether the callgraph execution should be triggered automatically after - * building the callstack or if it should wait to be requested. This is used - * in benchmark to control when the callgraph module will be built. + * Set whether the callgraph execution should be triggered automatically + * after building the callstack or if it should wait to be requested. This + * is used in benchmark to control when the callgraph module will be built. * * @param trigger - * {@code true} means the callgraph analysis will be executed after - * the callstack, {@code false} means it will be executed on demand - * only. + * {@code true} means the callgraph analysis will be executed + * after the callstack, {@code false} means it will be executed + * on demand only. * @since 1.1 */ @VisibleForTesting public void triggerAutomatically(boolean trigger) { fAutomaticCallgraph = trigger; } - -} \ No newline at end of file +}