Fix #354 Allow to use a remote target platform file

[laeubi]

FYI @vogella

[vogella]

Looks great from what I can see in the webeditor. I can try this locally by the end of this week, if desired. I guess a similar change would be required in PDE to support a smooth developer experience.

[mickaelistria]

Code looks good and safe. A test that covers that would be welcome to prevent from further regressions.
@vogella Please try it (run mvn install -DskipTests locally and then use the 2.6.0-SNAPSHOT) and report whether it's a good solution for #354.

[github-actions]

Unit Test Results

142 files  142 suites   46m 47s ⏱️
223 tests 220 ✔️ 3 💤 0 ❌

Results for commit 8e445f2.

♻️ This comment has been updated with latest results.

[vogella]

Does not work for me, most likely an error on my side:

Steps:
1.) cloned tycho and integrated pr
2.) mvn clean verify (with Java 11 runtime, Java 17 runtime fails)
3.) Set 2.6.0-SNAPSHOT -> build worked
4.) Replaced file reference in target with https://... -> build fails

Example: https://github.com/vogellacompany/eclipse4book/tree/testing-tycho-http-targetfile

[laeubi]

Replaced file reference in target with https://... -> build fails

Have you used (note the <uri> tag instead of <file> tag) it like this?

 <plugin>
	<groupId>org.eclipse.tycho</groupId>
	<artifactId>target-platform-configuration</artifactId>
	<version>${tycho.version}</version>
	<configuration>
		<target>
			<uri>https://raw.githubusercontent.com/vogellacompany/eclipse4book/testing-tycho-http-targetfile/target-platform/target-platform.target</uri>
		</target>
	   ...
	</configuration>
</plugin>

build fails

Wich error is given?

[vogella]

@laeubi thanks for the help.

Yes, with uri it works fine.

Great contributions, thanks again. I opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=577005 for a similar enhancement in PDE.

[laeubi]

Thanks for verification