Add validty check function to UUri #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a function for checking if an existing UUri is a valid uProtocol URI.
Contributor
Author
|
@PLeVasseur is this what you need for uStreamer? |
PLeVasseur
reviewed
Nov 12, 2024
Contributor
There was a problem hiding this comment.
Thanks @sophokles73!
I think this is one half of what I was suggesting adding, please see comments for details.
| } | ||
| } | ||
|
|
||
| fn verify_major_version(major_version: u32) -> Result<u8, UUriError> { |
Contributor
There was a problem hiding this comment.
👍 Yup, this is definitely one of the functions that'd be useful to have.
| /// ``` | ||
| pub fn check_validity(&self) -> Result<(), UUriError> { | ||
| Self::verify_authority(self.authority_name.as_str())?; | ||
| Self::verify_major_version(self.ue_version_major)?; |
Contributor
There was a problem hiding this comment.
Could you also add a verify_resource_id() that'd attempt the conversion to a u16 and include calling that function in here too?
Contributor
Author
There was a problem hiding this comment.
Oh, absolutely. Don't know how that slipped through. Good that we do the reviews ... ;-)
Contributor
Author
|
@PLeVasseur I have added a corresponding check ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function for checking if an existing UUri is a valid
uProtocol URI.
Addresses #209