Improve MSRV checking #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophokles73
added
enhancement
sophokles73
force-pushed
the
improve_msrv_checking
branch
from
27ef4b8 to
6728e06
Compare
The only file inside was an empty test which did not verify anything.
Updated GitHub workflow for checking the MSRV to use the cargo-hack tool which is also recommended by the Cargo book. Also updated crate's MSRV to 1.76 because the "tests" target failed the check for 1.74.1.
The nightly workflow has been extended with a job that verifies if the crate can be built with the latest (compatible) versions of all dependencies. The job will not fail the overall workflow execution but provides an indication that the crate's MSRV might need to be adapted.
sophokles73
force-pushed
the
improve_msrv_checking
branch
from
6728e06 to
569b051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated GitHub workflow for checking the MSRV to use the cargo-hack tool
which is also recommended by the Cargo book.
Also updated crate's MSRV to 1.76 because the "tests" target failed the
check for 1.74.1.
The nightly workflow has been extended with a job that verifies if the
crate can be built with the latest (compatible) versions of all
dependencies. The job will not fail the overall workflow execution
but provides an indication that the crate's MSRV might need to be
adapted.