Feature/support conan package creation from local build #32
Conversation
support-conan-package-creation-from-local-build
There was a problem hiding this comment.
This change makes it impossible to build this library on a standard Ubuntu 22.04 machine. I would recommend testing using the instructions in README.md in a clean Ubuntu environment (e.g. docker run -it ubuntu:22.04) to verify your changes are good. Feel free to update the README if there are any process changes (e.g. build steps, flags for conan or cmake, etc).
The process of verifying the build steps will start with building and installing zenoh-c.
I'd also like for you to update both the commits and this review with a meaningful description of what these changes are and what they do. The commits can be squashed and reworded however you best feel conveys the content of your work using git rebase -i ....
up-cpp package will be used from conan package always
Updated how to build bundled build
update build commands
updated conan package create command for conan 2.x
GitHub will fall back to the cache from the target branch of a PR if it fails to find a cache for the source branch of a PR. This causes issues if the PR is changing the ci.yml file (see eclipse-uprotocol#32) without one of the dependency repos changing (up-cpp and zenoh-c). This change adds the SHA of the workflow file to the cache key so that changes to ci.yml will invalidate the caches. While this reduces the value of the caches when iterating on ci.yml changes, a developer working in ci.yml would have the ability to remove this temporarily if needed.
GitHub will fall back to the cache from the target branch of a PR if it fails to find a cache for the source branch of a PR. This causes issues if the PR is changing the ci.yml file (see eclipse-uprotocol#32) without one of the dependency repos changing (up-cpp and zenoh-c). This change adds the SHA of the workflow file to the cache key so that changes to ci.yml will invalidate the caches. While this reduces the value of the caches when iterating on ci.yml changes, a developer working in ci.yml would have the ability to remove this temporarily if needed.
|
The CI cache issue with the up-cpp step is fixed by #36. We will get that merged so you can rebase your PR onto the fix. |
|
Closing stale pull requests. We are tracking conan recipes on the 1.5.8 project board. |
Feature/support conan package creation from local build