From 33e4c2600594100dac56d5daadeca69355b4abfc Mon Sep 17 00:00:00 2001 From: Francesco Guardiani Date: Wed, 17 Jan 2018 22:44:24 +0100 Subject: [PATCH] Changed ws.closeWithReason() name to ws.close() Signed-off-by: francesco --- src/main/java/io/vertx/core/http/WebSocketBase.java | 2 +- .../java/io/vertx/core/http/impl/WebSocketImplBase.java | 2 +- src/test/java/io/vertx/test/core/WebsocketTest.java | 7 ++----- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/main/java/io/vertx/core/http/WebSocketBase.java b/src/main/java/io/vertx/core/http/WebSocketBase.java index 48d1832904c..aedf0503417 100644 --- a/src/main/java/io/vertx/core/http/WebSocketBase.java +++ b/src/main/java/io/vertx/core/http/WebSocketBase.java @@ -246,7 +246,7 @@ public interface WebSocketBase extends ReadStream, WriteStream { * @param statusCode Status code * @param reason reason of closure */ - void closeWithReason(short statusCode, @Nullable String reason); + void close(short statusCode, @Nullable String reason); /** * @return the remote address for this socket diff --git a/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java b/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java index cad616fb2a9..1c014ebaad4 100644 --- a/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java +++ b/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java @@ -98,7 +98,7 @@ public void close() { } } - public void closeWithReason(short statusCode, String reason) { + public void close(short statusCode, String reason) { synchronized (conn) { checkClosed(); conn.closeWithPayload(WebSocketCloseFrameCode.generateByteBuffer(statusCode, reason)); diff --git a/src/test/java/io/vertx/test/core/WebsocketTest.java b/src/test/java/io/vertx/test/core/WebsocketTest.java index 56ede782b36..29bf7b4f0d8 100644 --- a/src/test/java/io/vertx/test/core/WebsocketTest.java +++ b/src/test/java/io/vertx/test/core/WebsocketTest.java @@ -12,8 +12,6 @@ package io.vertx.test.core; -import io.netty.buffer.ByteBuf; -import io.netty.buffer.Unpooled; import io.netty.handler.codec.http.websocketx.WebSocketHandshakeException; import io.vertx.core.AbstractVerticle; import io.vertx.core.AsyncResult; @@ -48,7 +46,6 @@ import io.vertx.core.streams.ReadStream; import io.vertx.test.core.tls.Cert; import io.vertx.test.core.tls.Trust; -import org.junit.Ignore; import org.junit.Test; import javax.security.cert.X509Certificate; @@ -2142,7 +2139,7 @@ public void testCloseCustomPayloadFromServer() throws InterruptedException { socket.closeHandler(a -> { latch.countDown(); }); - vertx.setTimer(1000, (ar) -> socket.closeWithReason(STATUS_CODE, REASON)); + vertx.setTimer(1000, (ar) -> socket.close(STATUS_CODE, REASON)); }) .listen(ar -> { client.websocket(HttpTestBase.DEFAULT_HTTP_PORT, HttpTestBase.DEFAULT_HTTP_HOST, "/", ws -> { @@ -2176,7 +2173,7 @@ public void testCloseCustomPayloadFromClient() throws InterruptedException { }) .listen(ar -> { client.websocket(HttpTestBase.DEFAULT_HTTP_PORT, HttpTestBase.DEFAULT_HTTP_HOST, "/", ws -> { - ws.closeWithReason(STATUS_CODE, REASON); + ws.close(STATUS_CODE, REASON); }); }); awaitLatch(latch);