Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTTP/1.1 decode errors #1862

Closed
vietj opened this issue Mar 8, 2017 · 0 comments
Closed

Handle HTTP/1.1 decode errors #1862

vietj opened this issue Mar 8, 2017 · 0 comments

Comments

@vietj
Copy link
Member

@vietj vietj commented Mar 8, 2017

Motivation: when the Netty HTTP/1.x decoder finds a protocol error (invalid chunk, initial line too long, etc...), it signals it with an error in the HttpObject. We handle it in a single case (http server invalid request) and we should handle it in all case on server request or in client response and make no further processing of the connection.

Changes: when an HttpObject is received we check there is no decode error. When there is a decode error we signal it to the HttpServerRequest or HttpClientResponse and then we close the connection.

@vietj vietj changed the title Improve http decode errors Improve HTTP/1.x decode errors Mar 8, 2017
@vietj vietj changed the title Improve HTTP/1.x decode errors Handle HTTP/1.1 decode errors Mar 8, 2017
@vietj vietj mentioned this issue Mar 8, 2017
29 of 29 tasks complete
@vietj vietj closed this Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.