Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new common Socket interface #1182

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@chirino
Copy link

commented Oct 20, 2015

implemented by both the NetSocket and WebSocket classes.

@purplefox purplefox added the to review label Oct 20, 2015

@purplefox

This comment has been minimized.

Copy link
Contributor

commented Nov 20, 2015

Going to close this as it's a breaking API change.

@purplefox purplefox closed this Nov 20, 2015

@purplefox purplefox removed the to review label Nov 20, 2015

@chirino

This comment has been minimized.

Copy link
Author

commented Nov 20, 2015

Is it actually a breaking API change? This introduces a new interface, but existing interfaces don't get any new methods for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.