Security manager removed from WB code #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the JDT clean-up actions I removed any trailing ws. This should make contributions easier as we do not have to see / review unrelated ws changes. Git history can be configured to ignore these. Cleanup is used multiple times and therefore I think it is saved. No manual review required IMHO. Fixes #74
This is just a re-format of the file so that the changes done via #73 are easier to see / read.
The security manager was checking for certain packages which seem partially outdated and prevent them from triggering a shutdown. AFAICS WB also works fine without this check and IMHO if someone wants to trigger a shutdown this should be ok, independently of the package. Also IIRC using custom security managers are planned to become more difficult in future Java versions, I think I have seen a discussion about this in Equinox. Fixes #72
lcaron
approved these changes
Oct 22, 2021
Contributor
Author
|
Looks like the save actions did modify the code. I dislike mixing format changes and real change. Let me open an issue for whitespace cleanup and potential apply the current format to some files. |
vogella
force-pushed
the
security-manager-removed
branch
from
acb4be8 to
476a561
Compare
vogella
added a commit
that referenced
this pull request
Oct 22, 2021
This is just a re-format of the file so that the changes done via #73 are easier to see / read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security manager was checking for certain packages which seem
partially outdated and prevent them from triggering a shutdown. AFAICS
WB also works fine without this check and IMHO if someone wants to
trigger a shutdown this should be ok, independently of the package.
Also IIRC using custom security managers are planned to become more
difficult in future Java versions, I think I have seen a discussion
about this in Equinox.
Fixes #72