fix(links): correct IPv6 address parsing for TLS and QUIC locators (#2138)

Fix IPv6 parsing where `get_*_host()` functions incorrectly handled
square brackets, causing "[::1]:7447" to become "[:7447" in HELLO
messages.

Use `rsplit_once` instead of `split` in host computation.

Author: steils

io/zenoh-link-commons/src/quic.rs

@@ -513,11 +513,11 @@ pub async fn get_quic_addr(address: &Address<'_>) -> ZResult<SocketAddr> {
 }
 
 pub fn get_quic_host<'a>(address: &'a Address<'a>) -> ZResult<&'a str> {
-    address
+    Ok(address
         .as_str()
-        .split(':')
-        .next()
-        .ok_or_else(|| zerror!("Invalid QUIC address").into())
+        .rsplit_once(':')
+        .ok_or_else(|| zerror!("Invalid QUIC address"))?
+        .0)
 }
 
 pub fn base64_decode(data: &str) -> ZResult<Vec<u8>> {

io/zenoh-links/zenoh-link-quic/src/utils.rs

@@ -507,11 +507,11 @@ pub async fn get_quic_addr(address: &Address<'_>) -> ZResult<SocketAddr> {
 }
 
 pub fn get_quic_host<'a>(address: &'a Address<'a>) -> ZResult<&'a str> {
-    address
+    Ok(address
         .as_str()
-        .split(':')
-        .next()
-        .ok_or_else(|| zerror!("Invalid QUIC address").into())
+        .rsplit_once(':')
+        .ok_or_else(|| zerror!("Invalid QUIC address"))?
+        .0)
 }
 
 pub fn base64_decode(data: &str) -> ZResult<Vec<u8>> {

io/zenoh-links/zenoh-link-tls/src/utils.rs

@@ -595,11 +595,11 @@ pub async fn get_tls_addr(address: &Address<'_>) -> ZResult<SocketAddr> {
 }
 
 pub fn get_tls_host<'a>(address: &'a Address<'a>) -> ZResult<&'a str> {
-    address
+    Ok(address
         .as_str()
-        .split(':')
-        .next()
-        .ok_or_else(|| zerror!("Invalid TLS address").into())
+        .rsplit_once(':')
+        .ok_or_else(|| zerror!("Invalid TLS address"))?
+        .0)
 }
 
 pub fn get_tls_server_name<'a>(address: &'a Address<'a>) -> ZResult<ServerName<'a>> {