revert change of T68653

eclipse-birt · Nov 8, 2013 · e888f07 · e888f07
1 parent a8d2221
commit e888f07
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/...art.reportitem.ui/src/org/eclipse/birt/chart/reportitem/ui/ReportDataServiceProvider.java b/...art.reportitem.ui/src/org/eclipse/birt/chart/reportitem/ui/ReportDataServiceProvider.java
@@ -1731,10 +1731,9 @@ protected IQueryResults executeDataSetQuery( QueryDefinition queryDefn )
 	 * @param queryDefn
 	 * @throws AdapterException
 	 * @throws DataException
-	 * @throws ChartException 
 	 */
 	protected void setQueryDefinitionWithDataSet( Chart cm, ExtendedItemHandle handle,
-			QueryDefinition queryDefn ) throws AdapterException, DataException, ChartException
+			QueryDefinition queryDefn ) throws AdapterException, DataException
 	{
 		// Iterate parameter bindings to check if its expression is a
 		// explicit
@@ -1744,13 +1743,7 @@ protected void setQueryDefinitionWithDataSet( Chart cm, ExtendedItemHandle handl
 
 		// Add bindings and filters from report handle.
 		Iterator<?> bindingIt = getUsedDataSetBindings( cm,  handle );
-		if ( bindingIt == null || !bindingIt.hasNext( ) )
-		{
-			throw new ChartException( ChartReportItemPlugin.ID,
-					ChartException.DATA_BINDING,
-					Messages.getString( "exception.no.valid.binding" ) ); //$NON-NLS-1$
-		}
-		while ( bindingIt.hasNext( ) )
+		while ( bindingIt != null && bindingIt.hasNext( ) )
 		{
 			Object computedBinding = bindingIt.next( );
 			IBinding binding = session.getModelAdaptor( )

diff --git a/...pse.birt.chart.reportitem.ui/src/org/eclipse/birt/chart/reportitem/ui/i18n/nls.properties b/...pse.birt.chart.reportitem.ui/src/org/eclipse/birt/chart/reportitem/ui/i18n/nls.properties
@@ -106,5 +106,3 @@ ChartCubeFilterConditionBuilder.Expression.ValueItemPrefix=Value:
 ChartCubeFilterConditionBuilder.Expression.YOptionItem.Prefix=Y Option: 
 ChartCubeFilterConditionBuilder.SelectValueDialog.messages.info.selectVauleUnavailable=Value list unavailable with given expression.
 ChartCubeFilterConditionBuilder.SelectValueDialog.messages.info.illegalVauleExpr=Only the expression with format like data["name"]/[name] can get its value list.
-
-exception.no.valid.binding=No valid bindings. Please check if the expressions are correct.