Fix client hello #1021
Merged
Fix client hello #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider message sequence number also to determine, if a CLIENT_HELLO starts a new handshake. Signed-off-by: Achim Kraus <achim.kraus@bosch-si.com>
sbernard31
reviewed
Aug 7, 2019
| timer.schedule(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| handshaker.getConnection().isStartedByClientHello(null); |
There was a problem hiding this comment.
I don't really like the idea about a "isSomethingMethod" which is also a setter.
There is a startByClientHello method we could use it ?
| * Random used by client to start the handshake. | ||
| * | ||
| * Note: used outside of serial-execution! | ||
| * Random used by client to start the handshake. Maybe {@code null}, for |
| if (startRandom != null) { | ||
| return startRandom.equals(clientHello.getRandom()); | ||
| if (clientHello == null) { | ||
| startingClientHello = null; |
There was a problem hiding this comment.
Do we really need to set startingClientHello to null ? (see comment above)
| startingClientHello = null; | ||
| } else if (startingClientHello != null) { | ||
| if (startingClientHello.getRandom().equals(clientHello.getRandom())) { | ||
| if (startingClientHello.getMessageSeq() >= clientHello.getMessageSeq()) { |
There was a problem hiding this comment.
I do not understand this check ? Why using Random is not enough ? I guess this is maybe something about the initialization of Message Sequence number of handshaker but this is not clear to me :-/
| Connection sessionConnection = connections.getConnectionBySessionId(); | ||
| if (sessionConnection != null && sessionConnection != connection) { | ||
| // don't overwrite | ||
| verify = true; |
There was a problem hiding this comment.
This test should not be done in isClientInControlOfSourceIpAddress ?
If not, I would have remove the boolean and just do :
sendHelloVerify(clientHello, record, null);
return;
boaks
pushed a commit
that referenced
this pull request
Aug 7, 2019
Signed-off-by: Achim Kraus <achim.kraus@bosch-si.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achim Kraus achim.kraus@bosch-si.com