Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JS support for assemblies #6929

Closed
quintesse opened this issue Feb 23, 2017 · 8 comments
Closed

Implement JS support for assemblies #6929

quintesse opened this issue Feb 23, 2017 · 8 comments
Assignees
Labels
Milestone

Comments

@quintesse
Copy link
Contributor

@quintesse quintesse commented Feb 23, 2017

Right now we only support ceylon run --assembly, the same should work for ceylon run-js

@quintesse quintesse added the c-tools label Feb 23, 2017
@quintesse quintesse added this to the 1.3.2 milestone Feb 23, 2017
@quintesse quintesse self-assigned this Feb 23, 2017
@gavinking
Copy link
Member

@gavinking gavinking commented Feb 23, 2017

+1

@quintesse
Copy link
Contributor Author

@quintesse quintesse commented Feb 23, 2017

I've made this work for combined JVM/JS modules but JS-only modules are giving trouble unfortunately. Something to do with the code I copied from Stef.

@FroMage: is there a way to use the ModelGraph visitor to visit JS-only modules? It encounters 1st-level JS modules but they doesn't have an ArtifactResult associated with them and neither are their dependencies walked. Is that a known issue?

@quintesse quintesse closed this in 5493ab5 Feb 23, 2017
@gavinking
Copy link
Member

@gavinking gavinking commented Feb 24, 2017

Excellent work, @quintesse!

@quintesse
Copy link
Contributor Author

@quintesse quintesse commented Feb 24, 2017

Sorry, this isn't really done yet

@quintesse quintesse reopened this Feb 24, 2017
@FroMage
Copy link
Contributor

@FroMage FroMage commented Feb 24, 2017

Honestly I don't remember. There's no reason to not walk them AFAICT.

quintesse added a commit that referenced this issue Feb 24, 2017
…g with artifact types they don't know how to handle (see #6929)
@quintesse
Copy link
Contributor Author

@quintesse quintesse commented Feb 24, 2017

Ok, assemblies now not only can hold Ceylon JS modules but even NPM modules.

Unfortunately we don't have an NpmDependencyResolver in the CMR yet so we can't retrieve an NPM module's dependencies so for now this only works for very simple NPM modules.

@quintesse
Copy link
Contributor Author

@quintesse quintesse commented Feb 28, 2017

Ok, this now works for non-trivial NPM modules as well. Closing.

@quintesse quintesse closed this Feb 28, 2017
@gavinking
Copy link
Member

@gavinking gavinking commented Feb 28, 2017

Great! Thanks @quintesse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants