New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dirigible-che-editor-plugin #54

Merged
merged 2 commits into from Nov 5, 2018

Conversation

Projects
None yet
5 participants
@delchev
Copy link
Member

delchev commented Nov 2, 2018

…ins/org.eclipse.che.editor.dirigible/1.0.0/meta.yaml

What does this PR do?

Adding Eclipse Dirigible Che Plugin

Adding dirigible-che-editor-plugin
Signed-off-by: delchev <delchevn@gmail.com>

@benoitf benoitf requested review from benoitf , l0rd , skabashnyuk and sleshchenko Nov 2, 2018

@benoitf

benoitf approved these changes Nov 2, 2018

@slemeur

This comment has been minimized.

Copy link

slemeur commented Nov 3, 2018

Really cool ! thanks @delchev

@slemeur

This comment has been minimized.

Copy link

slemeur commented Nov 3, 2018

@benoitf who is going to merge this one?

@benoitf

This comment has been minimized.

Copy link
Member

benoitf commented Nov 3, 2018

I'm waiting other approvals then we can merge it

@benoitf

This comment has been minimized.

Copy link
Member

benoitf commented Nov 3, 2018

btw it seems CI job has failed. Need to investigate

@skabashnyuk
Copy link
Contributor

skabashnyuk left a comment

CI job report

 ---> Running in fe5b42f90abb
!!! ID mismatch in plugin 'org.eclipse.che.editor.dirigible/1.0.0':
!!!   id in meta.yaml: 'dirigible-che-editor-plugin'
!!!   id directory name: 'org.eclipse.che.editor.dirigible' 

other looks good

@@ -0,0 +1,8 @@
id: dirigible-che-editor-plugin

This comment has been minimized.

@skabashnyuk

skabashnyuk Nov 3, 2018

Contributor
Suggested change Beta
id: dirigible-che-editor-plugin
id: org.eclipse.che.editor.dirigible

This comment has been minimized.

@l0rd

l0rd Nov 5, 2018

Contributor

@skabashnyuk we don't have a naming convention yet. I wouldn't go with the Java packages naming anyway (too verbose). I have created #55 to discuss that.

This comment has been minimized.

@skabashnyuk

skabashnyuk Nov 5, 2018

Contributor

We have convention that path should be plugins/{id}/{version}/meta.yaml

title: Eclipse Dirigible for Eclipse Che
description: Eclipse Dirigible as App Development Platform for Eclipse Che
icon: https://www.dirigible.io/img/logo/dirigible-logo.png
url: https://github.com/dirigiblelabs/dirigible-che-editor-plugin/releases/download/1.0.0/dirigible-che-editor-plugin.tar.gz

This comment has been minimized.

@skabashnyuk

skabashnyuk Nov 3, 2018

Contributor
Suggested change Beta
url: https://github.com/dirigiblelabs/dirigible-che-editor-plugin/releases/download/1.0.0/dirigible-che-editor-plugin.tar.gz
url: https://github.com/dirigiblelabs/dirigible-che-editor-plugin/releases/download/1.0.0/dirigible-che-editor-plugin.tar.gz
@l0rd

l0rd approved these changes Nov 5, 2018

Fixed as suggested by @skabashnyuk
Signed-off-by: delchev <delchevn@gmail.com>

@skabashnyuk skabashnyuk merged commit 623ab9a into eclipse:master Nov 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment