Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vscode-shellcheck plugin in che-docs devfile #18900

Closed
themr0c opened this issue Jan 27, 2021 · 4 comments
Closed

Add vscode-shellcheck plugin in che-docs devfile #18900

themr0c opened this issue Jan 27, 2021 · 4 comments
Labels
area/doc Issues related to documentation kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@themr0c
Copy link
Contributor

themr0c commented Jan 27, 2021

Add vscode-shellcheck plugin in che-docs devfile.
If necessary, make sure the plugin is available in the plugin-registry.
See: https://github.com/timonwong/vscode-shellcheck
@themr0c themr0c added kind/task Internal things, technical debt, and to-do tasks to be performed. area/doc Issues related to documentation team/doc labels Jan 27, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 27, 2021
@ericwill
Copy link
Contributor

Yep, it's in the registry:

https://github.com/eclipse/che-plugin-registry/blob/master/che-theia-plugins.yaml#L492-L500
and
https://che-plugin-registry-main.surge.sh/v3/plugins/timonwong/shellcheck/0.10.1/meta.yaml

@themr0c
Copy link
Contributor Author

themr0c commented Jan 27, 2021 •
edited
Loading

So all what we need is to add this component in devfile, am I correct?

  - id: timonwong/shellcheck/latest
    type: chePlugin

@ericwill
Copy link
Contributor

So all what we need is to add this component in devfile, am I correct?

  - id: timonwong/shellcheck/latest
    type: chePlugin

As I understand it, it would be

- type: chePlugin
  id: timonwong/shellcheck/latest

@davidfestal davidfestal added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 27, 2021
@yhontyk yhontyk mentioned this issue Jan 29, 2021
Merged
6 tasks
@yhontyk
Copy link

yhontyk commented Feb 10, 2021

Docs team Jira https://issues.redhat.com/browse/RHDEVDOCS-2656

@themr0c themr0c closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/doc Issues related to documentation kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@themr0c @davidfestal @ericwill @yhontyk @che-bot