New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP support #2590

Closed
kaloyan-raev opened this Issue Sep 26, 2016 · 9 comments

Comments

Projects
None yet
5 participants
@kaloyan-raev
Member

kaloyan-raev commented Sep 26, 2016

This issue collects all items to be done in order to provide additional PHP support within Che.

General bugs affecting the PHP support too:

  • Editor does not filter code completion proposals from language server #2592
  • Formatting the whole document makes a big mess #2437
  • Language Server formatting options are hardcoded #2728
  • Performance issues with code completion #2815
  • Render hover messages according to LSP specification #2856
  • Add commands to workspace when importing project samples #2976
  • Issues with documentation popup for LSP code completion #3218
@kaloyan-raev

This comment has been minimized.

Show comment
Hide comment
@kaloyan-raev

kaloyan-raev Sep 26, 2016

Member

@TylerJewell I started collecting the list of items related to the PHP support. I hope you and the team find it useful.

Member

kaloyan-raev commented Sep 26, 2016

@TylerJewell I started collecting the list of items related to the PHP support. I hope you and the team find it useful.

@TylerJewell

This comment has been minimized.

Show comment
Hide comment
@TylerJewell

TylerJewell Sep 26, 2016

Contributor

There are some other marketing and documentation issues that will be needed. I added them to the list for consideration.

Contributor

TylerJewell commented Sep 26, 2016

There are some other marketing and documentation issues that will be needed. I added them to the list for consideration.

@kaloyan-raev kaloyan-raev referenced this issue Oct 4, 2016

Merged

Zend stack and project sample #2700

1 of 1 task complete

slemeur added a commit that referenced this issue Oct 5, 2016

Zend stack and project sample (#2700)
### What does this PR do?

Adds a stack with [Zend Server](http://www.zend.com/en/products/zend_server), based on the [official docker image](https://hub.docker.com/r/_/php-zendserver/). Zend Server is a professional and certified PHP distribution. The docker image includes a free trial Developer license.

Also adds a project sample of the [Astro Splash](https://github.com/kaloyan-raev/AstroSplash) application, which is a demo app based on the [Zend Expressive](https://zendframework.github.io/zend-expressive/) framework.

After creating a workspace with these stack and template the user must:

1. Execute the `configure` command.
2. Execute the `restart zend server` command.
3. Click on the preview link generated by the `restart zend server` command.

### What issues does this PR fix or reference?

- PHP support #2590

### New behavior

- New stack with Zend Server.
- New project sample: Astro Splash demo app, based on Zend Expressive.
@TylerJewell

This comment has been minimized.

Show comment
Hide comment
@TylerJewell

TylerJewell Oct 14, 2016

Contributor

@kaloyan-raev - if we plan to make a 5.0 announcement release for CheConf, can we think about which issues are likely to be ready and which ones are not likely to be ready in time for the event? It will affect how we message PHP support in the keynote that I give. Also, it would be nice for us to launch a PHP solution page - similar to what we did for SAP web IDE or Codenvy on eclipse.org/che. If you can create the HTML page + content, we'll get our marketing team to get it integrated into the site.

Contributor

TylerJewell commented Oct 14, 2016

@kaloyan-raev - if we plan to make a 5.0 announcement release for CheConf, can we think about which issues are likely to be ready and which ones are not likely to be ready in time for the event? It will affect how we message PHP support in the keynote that I give. Also, it would be nice for us to launch a PHP solution page - similar to what we did for SAP web IDE or Codenvy on eclipse.org/che. If you can create the HTML page + content, we'll get our marketing team to get it integrated into the site.

@kaloyan-raev

This comment has been minimized.

Show comment
Hide comment
@kaloyan-raev

kaloyan-raev Oct 14, 2016

Member

@TylerJewell All "checked" items are complete - merged in master.

@bartlomiej-laczkowski is working on the Zend Debugger integration. We already have breakpoints working, stepping and showing variables state. I hope we can have the PR in a week.

@mniewrzal is helping with felixfbecker/php-language-server. There is also a great community effort there. The language server improves rapidly. I believe we can have it as a replacement of the Crane server within a week.

These are the two major improvements for the moment. When is the deadline for new major PRs for the 5.0 release?

I'll take a look at the existing documentation. Perhaps, I will open another issue to discuss the changes.

Member

kaloyan-raev commented Oct 14, 2016

@TylerJewell All "checked" items are complete - merged in master.

@bartlomiej-laczkowski is working on the Zend Debugger integration. We already have breakpoints working, stepping and showing variables state. I hope we can have the PR in a week.

@mniewrzal is helping with felixfbecker/php-language-server. There is also a great community effort there. The language server improves rapidly. I believe we can have it as a replacement of the Crane server within a week.

These are the two major improvements for the moment. When is the deadline for new major PRs for the 5.0 release?

I'll take a look at the existing documentation. Perhaps, I will open another issue to discuss the changes.

@TylerJewell

This comment has been minimized.

Show comment
Hide comment
@TylerJewell

TylerJewell Oct 14, 2016

Contributor

You probably need to have a PR open by 10/31 for it to have a chance to be merged for the milestone build that we'll use for promotion purposes at CheConf. We'll try to issue that release, whether it's M7 or M8 by November 8th. We are not sure if that will be the GA build or not, but M5 is pretty stable and M6 is focused on exclusively customer issues, so things are rapidly moving in that direction.

Contributor

TylerJewell commented Oct 14, 2016

You probably need to have a PR open by 10/31 for it to have a chance to be merged for the milestone build that we'll use for promotion purposes at CheConf. We'll try to issue that release, whether it's M7 or M8 by November 8th. We are not sure if that will be the GA build or not, but M5 is pretty stable and M6 is focused on exclusively customer issues, so things are rapidly moving in that direction.

@kaloyan-raev

This comment has been minimized.

Show comment
Hide comment
@kaloyan-raev

kaloyan-raev Oct 14, 2016

Member

OK. 10/31 sounds good to me.

Member

kaloyan-raev commented Oct 14, 2016

OK. 10/31 sounds good to me.

@tolusha tolusha referenced this issue Dec 8, 2016

Merged

Zend debugger #1306

JPinkney pushed a commit to JPinkney/che that referenced this issue Aug 17, 2017

Zend stack and project sample (eclipse#2700)
### What does this PR do?

Adds a stack with [Zend Server](http://www.zend.com/en/products/zend_server), based on the [official docker image](https://hub.docker.com/r/_/php-zendserver/). Zend Server is a professional and certified PHP distribution. The docker image includes a free trial Developer license.

Also adds a project sample of the [Astro Splash](https://github.com/kaloyan-raev/AstroSplash) application, which is a demo app based on the [Zend Expressive](https://zendframework.github.io/zend-expressive/) framework.

After creating a workspace with these stack and template the user must:

1. Execute the `configure` command.
2. Execute the `restart zend server` command.
3. Click on the preview link generated by the `restart zend server` command.

### What issues does this PR fix or reference?

- PHP support eclipse#2590

### New behavior

- New stack with Zend Server.
- New project sample: Astro Splash demo app, based on Zend Expressive.
@slemeur

This comment has been minimized.

Show comment
Hide comment
@slemeur

slemeur Sep 6, 2017

Contributor

@kaloyan-raev Are you agree to close this epic as most of the items have been covered? Maybe another epic should be opened to highlight potential advanced capabilities that you would like to introduce.

Contributor

slemeur commented Sep 6, 2017

@kaloyan-raev Are you agree to close this epic as most of the items have been covered? Maybe another epic should be opened to highlight potential advanced capabilities that you would like to introduce.

@kaloyan-raev

This comment has been minimized.

Show comment
Hide comment
@kaloyan-raev

kaloyan-raev Sep 11, 2017

Member

@slemeur Yes. Let's close it.

Member

kaloyan-raev commented Sep 11, 2017

@slemeur Yes. Let's close it.

@madalinignisca

This comment has been minimized.

Show comment
Hide comment
@madalinignisca

madalinignisca Mar 8, 2018

Will Xdebug be ever supported?

Zend Debugger won't run with PHP 7.2 and it's not nice to have to wait for Zend to work it out on each new PHP release to update their closed source extension. From their history it can be many months...

By the way, is there any reasons not to make Xdebug a priority and default as it's 100% open source and support the closed source Zend Debugger extension?

madalinignisca commented Mar 8, 2018

Will Xdebug be ever supported?

Zend Debugger won't run with PHP 7.2 and it's not nice to have to wait for Zend to work it out on each new PHP release to update their closed source extension. From their history it can be many months...

By the way, is there any reasons not to make Xdebug a priority and default as it's 100% open source and support the closed source Zend Debugger extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment