Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to cancel rename operation #11886

Merged
merged 2 commits into from Nov 12, 2018
Merged

Add ability to cancel rename operation #11886

merged 2 commits into from Nov 12, 2018

Conversation

RomanNikitenko
Copy link
Member

What does this PR do?

  • Increase timeout for rename operation from 10 sec to 30 sec

  • Add ability to cancel rename operation

  • Add loader for 'OK' button to display state when operation is in progress
    rename_new

  • Fix NPE and provide error message for case when operation is interrupted by timeout:
    Current behavior:
    rename_current_timeout
    The new behavior:
    rename_timeout_new

  • improve a little process of validation name:
    Current state - we send request per each inputted character
    validate_current

The new behavior: while user is typing - we are waiting, when he stopped - we send request to validate new name
validate_new

What issues does this PR fix or reference?

#10784 #11754

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

@RomanNikitenko RomanNikitenko added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 9, 2018
@RomanNikitenko
Copy link
Member Author

ci-test

@riuvshin
Copy link
Contributor

riuvshin commented Nov 9, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11886
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@RomanNikitenko
Copy link
Member Author

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11886
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@RomanNikitenko
Copy link
Member Author

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11886
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1158/) doesn't show any regression against this Pull Request.

@RomanNikitenko RomanNikitenko added this to the 6.14.0 milestone Nov 12, 2018
@RomanNikitenko RomanNikitenko merged commit 386a529 into master Nov 12, 2018
@RomanNikitenko RomanNikitenko deleted the CHE-10784 branch November 12, 2018 13:02
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants