CHE-5334. Fix hover state #5899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanNikitenko
added
the
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3275/ |
SkorikSergey
approved these changes
Aug 7, 2017
tsmaeder
reviewed
Aug 7, 2017
| @@ -363,7 +365,18 @@ public boolean canDo(InitializedLanguageServer element) { | |||
| @Override | |||
| public boolean handleResult(InitializedLanguageServer element, Hover hover) { | |||
| if (hover != null) { | |||
| result.getContents().addAll(hover.getContents()); | |||
| List<Either<String, MarkedString>> contents = | |||
There was a problem hiding this comment.
There is a constructor that makes a HoverDto out of a Hover in the generated HoverDto class. It may be simpler and safer to use that one.
There was a problem hiding this comment.
@tsmaeder fixed, thank you!
dkuleshov
approved these changes
Aug 7, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3295/ |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
CHE-5334
branch
from
8062061
to
8cd2ea4
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3311/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix hover state
What issues does this PR fix or reference?
#5334
Changelog
Fix hover state
Signed-off-by: Roman Nikitenko rnikiten@redhat.com