Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug #83

Merged
merged 1 commit into from Jan 29, 2020
Merged

Use debug #83

merged 1 commit into from Jan 29, 2020

Conversation

@makandre
Copy link
Contributor

makandre commented Jan 28, 2020

Signed-off-by: Andrew Mak makandre@ca.ibm.com

Resolves eclipse/codewind#1708

use debug
Signed-off-by: Andrew Mak <makandre@ca.ibm.com>
@sghung
sghung approved these changes Jan 29, 2020
Copy link
Contributor

sghung left a comment

Changes look good. Tested debug with nodejs and open liberty in vscode and eclipse. Ensured breakpoint is hit. Also bashed into the pfe container to verify these PR changes are in.

@sghung sghung merged commit 5381f07 into eclipse:master Jan 29, 2020
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
@makandre makandre deleted the makandre:debug branch Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.