Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added portal updates, waiting on PR for one of the fix list items #267

Merged
merged 11 commits into from Dec 18, 2019

Conversation

@beccabau
Copy link
Contributor

beccabau commented Dec 13, 2019

Signed-off-by: beccabau rbau@us.ibm.com

Signed-off-by: beccabau <rbau@us.ibm.com>
docs/_news/news07.md Outdated Show resolved Hide resolved
docs/_news/news07.md Outdated Show resolved Hide resolved
Signed-off-by: beccabau <rbau@us.ibm.com>
docs/_news/news07.md Outdated Show resolved Hide resolved
Signed-off-by: beccabau <rbau@us.ibm.com>
docs/_news/news07.md Outdated Show resolved Hide resolved
docs/_news/news07.md Outdated Show resolved Hide resolved
beccabau added 3 commits Dec 16, 2019
Signed-off-by: beccabau <rbau@us.ibm.com>
Signed-off-by: beccabau <rbau@us.ibm.com>
Signed-off-by: beccabau <rbau@us.ibm.com>
docs/_news/news07.md Outdated Show resolved Hide resolved
docs/_news/news07.md Outdated Show resolved Hide resolved
docs/_news/news07.md Outdated Show resolved Hide resolved
Signed-off-by: beccabau <rbau@us.ibm.com>
Copy link

rwalle61 left a comment

I've only reviewed the bit about metrics injection and the new app monitoring dash. LGTM except for one point

docs/_news/news07.md Outdated Show resolved Hide resolved
Signed-off-by: beccabau <rbau@us.ibm.com>
@tetchel

This comment was marked as spam.

Copy link
Contributor

tetchel commented Dec 17, 2019

no mention of hybrid?

@tetchel tetchel closed this Dec 17, 2019
@tetchel tetchel reopened this Dec 17, 2019
docs/_news/news07.md Outdated Show resolved Hide resolved
@sghung

This comment has been minimized.

Copy link
Contributor

sghung commented Dec 17, 2019

For openapi Eclipse, there were improvements (these were changes to make the eclipse experience the same as vscode, which had these features in last release):

Specifically, this change includes fixes to ensure the project compiles successfully after code generation:

  • The OpenAPI Wizard generator will not override the implicitly or explicitly defined main class in the Spring project
  • The compilation errors related to unimplemented methods in the OpenAPI2SpringBoot class are fixed. Therefore, in the OpenAPI troubleshooting section, remove the statement: "The Spring server generator creates invalid source in the OpenAPI2SpringBoot class. Simply implement the methods from the interface and save the file."
docs/_news/news07.md Outdated Show resolved Hide resolved
beccabau added 2 commits Dec 17, 2019
Signed-off-by: beccabau <rbau@us.ibm.com>
Signed-off-by: beccabau <rbau@us.ibm.com>
@sghung
sghung approved these changes Dec 18, 2019
Copy link
Contributor

sghung left a comment

Changes look good, thanks for including the proper issue number.

@sghung

This comment has been minimized.

Copy link
Contributor

sghung commented Dec 18, 2019

@keithchong can you also review the text for open API too? Thank you

@elsony
elsony approved these changes Dec 18, 2019
docs/_news/news07.md Outdated Show resolved Hide resolved
Signed-off-by: beccabau <rbau@us.ibm.com>
Copy link
Contributor

tobespc left a comment

LGTM

@jopit
jopit approved these changes Dec 18, 2019

#### List of Fixes
- Changes to the Eclipse plugin for Spring Server [post-code generation stability for OpenAPI](https://github.com/eclipse/codewind/issues/1116)
- Appsody binary updated from 0.5.0 to 0.5.2 in the codewind-appsody-extension
- Changes to the Eclipse plug-in for Spring server [post-code generation stability for OpenAPI](https://github.com/eclipse/codewind/issues/1116)

This comment has been minimized.

Copy link
@sishida

sishida Dec 18, 2019

Contributor

What about..."Improvements to OpenApi Eclipse, including fixes to ensure that the project compiles successfully after code generation."

@sishida sishida merged commit 7522c55 into eclipse:master Dec 18, 2019
1 check passed
1 check passed
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
@beccabau beccabau deleted the beccabau:becca_1240_last07mods branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.