Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify multiple docker registry credentials #1178

Closed
jopit opened this issue Nov 18, 2019 · 14 comments
Closed

Allow user to specify multiple docker registry credentials #1178

jopit opened this issue Nov 18, 2019 · 14 comments

Comments

@jopit
Copy link

@jopit jopit commented Nov 18, 2019

If the user has an Appsody project with a custom stack/collection for which images are pushed to a registry other than Docker Hub, the project is unable to build because the codewind container does not have the credentials to login to internal docker registry to pull the required images.

To fix this, we need to allow the user to specify credentials for a number of image registries that PFE can use to pull the images.

See Codewind not able to work with stacks images in the internal registry/non-docker hub
See Dynamic registry setup for the local scenario
See [Hybrid] Create docker registry secret in kube

@jopit

This comment has been minimized.

Copy link
Author

@jopit jopit commented Nov 19, 2019

No way to tell if an Appsody project requires credentials to access the associated docker registry.

Hybrid & Che

  • User needs to specify zero or one docker registries to for Codewind projects to push images to
  • User needs to specify zero or more docker registries for Appsody projects to pull stack images from

Local

  • User needs to specify zero or more docker registries for Appsody projects to pull stack images from

The registry to push Codewind projects to may or may not also be a registry to pull Appsody stacks from.

@jopit jopit added the area/design label Nov 20, 2019
@jopit

This comment has been minimized.

Copy link
Author

@jopit jopit commented Nov 20, 2019

Hybrid & Che

  • When the user first creates a codewind project, prompt for the docker registry needed for push

Local, Hybrid & Che

  • Add an item to the connection's context menu to show a 'manage container registries' page which allows user's to add, remove and edit the list of registries that PFE knows about. The list should also contain the registry needed for push if it exists. The user should be able to change which registry is used for the push from this page.
@tetchel tetchel changed the title Allow user to specify docker registry for Appsody on the local connection Allow user to specify multiple docker registry credentials Nov 21, 2019
@makandre

This comment has been minimized.

Copy link
Contributor

@makandre makandre commented Nov 25, 2019

When users enter the registry credentials in the IDEs, I'd like to propose that we do a local docker login as well; this would serve 2 purpose:

  • we can make sure the creds work before posting them to PFE
  • a successful login makes the creds available to local docker for pulling (this is for appsody init which happens locally)
@j-c-berger

This comment has been minimized.

Copy link

@j-c-berger j-c-berger commented Nov 26, 2019

Feel free to assign me @micgibso and @sishida

@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Nov 29, 2019

here's the existing page which will be mostly out of date after 0.7 https://www.eclipse.org/codewind/dockerregistry.html

@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Dec 6, 2019

@eharris369

This comment has been minimized.

Copy link

@eharris369 eharris369 commented Dec 9, 2019

@j-c-berger @sishida There is a "Learn more" link in the Manage Registries dialog that needs a URL for the documentation for this feature. Can you give us a URL even if the documentation is not complete yet so we can update the code?

@sishida

This comment has been minimized.

Copy link
Contributor

@sishida sishida commented Dec 9, 2019

@eharris369 This is the main Docker registry file that I am aware of: https://www.eclipse.org/codewind/dockerregistry.html

If we want to use this link, we should add a new section about specifying multiple Docker registry credentials. We could also link directly to this new section.

@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Dec 9, 2019

Steps 1 and 2 in the linked page are invalid now and should be replaced by the new documentation

@eharris369

This comment has been minimized.

Copy link

@eharris369 eharris369 commented Dec 9, 2019

Should the examples use the same terms as in the IDEs? Address for host (docker.io) and namespace for the <username> part of docker.io/<username>?

image

(Feel free to suggest improvements to any of the strings in the above dialog.)

@sishida

This comment has been minimized.

Copy link
Contributor

@sishida sishida commented Dec 9, 2019

I generally lean on the side of consistency. So unless there's a reason to change up the terms, my vote is for using the same terms. :)

Also, here are some minor edits:

  • "Provide registries for projects that need to pull content to build. You can designate a single registry as a push registry."
    • The desktop checker recommends "to" instead of "in order to" because it's less wordy.
    • I also changed the second sentence to active voice.
  • "Username" should be one word unless it's already two words throughout Eclipse.
@j-c-berger

This comment has been minimized.

Copy link

@j-c-berger j-c-berger commented Dec 10, 2019

@jopit, as always, thank you for the detailed and spot-on feedback! Looking forward to progressing with this issue.

@tetchel, question regarding your comment on steps 1 and 2 for the dockerregistry doc: https://www.eclipse.org/codewind/dockerregistry.html

Do we want to replace steps 1 and 2 with the content that I'm developing now? Basically, this issue will focus on dockerregistry and update those steps? Or, will I be making a whole new doc for this issue (as we earlier discussed) and update dockerregistry? In which case, I can open a second issue for the latter since there will be two separate docs being worked on. Thanks!

@maysunfaisal

This comment has been minimized.

Copy link
Contributor

@maysunfaisal maysunfaisal commented Dec 13, 2019

@j-c-berger with regards to the question addressed to @tetchel, I have put a comment on PR https://github.com/eclipse/codewind-docs/pull/261/files#r357857126

Steps 1 and 2 needs to be merged, because they;re now done with the same UI (Image Registries):
Screen Shot 2019-12-13 at 5 36 29 PM

But the keys and commands in the doc are no longer relevant with the new UI. See the screenshot above for reference. And I think we can still host the doc at https://www.eclipse.org/codewind/dockerregistry.html

@sishida

This comment has been minimized.

Copy link
Contributor

@sishida sishida commented Dec 18, 2019

Got confirmation from @j-c-berger that this issue is good to close. :)

@sishida sishida closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.