Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism in IDEs to set log level for PFE #1251

Closed
johnmcollier opened this issue Nov 22, 2019 · 19 comments
Closed

Add mechanism in IDEs to set log level for PFE #1251

johnmcollier opened this issue Nov 22, 2019 · 19 comments

Comments

@johnmcollier
Copy link
Member

@johnmcollier johnmcollier commented Nov 22, 2019

Currently, if a user needs to change the default log level (such as trace) in Codewind/PFE, they have to exec into the container and run:

> curl --header "Content-Type: application/json" --request PUT --data '{"level":"<level>"}' http://127.0.0.1:10000/api/v1/logging

This is unintuitive for the user (and also undocumented!). There needs to be a better way for users to configure the log level in PFE, especially to assist with problem determination.

Would it be possible to add something to the IDEs to allow the user to configure the log level for a Codewind instance?

@johnmcollier johnmcollier changed the title Add mechanism in IDES to set log level for PFE Add mechanism in IDEs to set log level for PFE Nov 22, 2019
@johnmcollier

This comment has been minimized.

Copy link
Member Author

@johnmcollier johnmcollier commented Nov 22, 2019

Adding just the IDE tags for now since I don't think this will require a change on the Portal side.

@eharris369

This comment has been minimized.

Copy link

@eharris369 eharris369 commented Nov 22, 2019

@johnmcollier

This comment has been minimized.

Copy link
Member Author

@johnmcollier johnmcollier commented Nov 27, 2019

Reopening as we still need this for VS Code, Theia, and IntelliJ

@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Dec 11, 2019

curious where you'd expect to find this in the UI

@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Jan 9, 2020

it would be added as a command with no 'regular' UI in VS Code

@johnmcollier

This comment has been minimized.

Copy link
Member Author

@johnmcollier johnmcollier commented Jan 9, 2020

What about also when you right click on the connection?

@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Jan 9, 2020

I don't really want to clutter the UI with something so niche

@johnmcollier

This comment has been minimized.

Copy link
Member Author

@johnmcollier johnmcollier commented Jan 9, 2020

I understand the point about not wanting to clutter things up, but is enabling verbose logging niche though?

@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Jan 9, 2020

It should be, if it's not, shouldn't we make the default logging more useful?

@johnmcollier

This comment has been minimized.

Copy link
Member Author

@johnmcollier johnmcollier commented Jan 9, 2020

That’s fair. I’m fine with having just a simple command then.

@eharris369

This comment has been minimized.

Copy link

@eharris369 eharris369 commented Jan 10, 2020

In Eclipse I will add a preference to enable support features. If the preference is enabled then the menus will include setting PFE log level items.

@jgwest

This comment has been minimized.

Copy link
Member

@jgwest jgwest commented Jan 10, 2020

Now the cwctl is (more) easily accessible by the user -- since we copy it under ~/.codewind -- an alternative to adding this mechanism to the IDE would be to add a cwctl logging command.

IIRC when we initially discussed adding this mechanism to the IDE, cwctl was not (yet) something we were making it easy for the user to access, whereas now it is in a fixed location.

(But feel free to ignore this if there is already momentum on implementing it in the IDEs)

@jgwest

This comment has been minimized.

Copy link
Member

@jgwest jgwest commented Jan 16, 2020

Howard has added a cwctl loglevels command that does the above: eclipse/codewind-installer#336 (though I think only for remote PFE at this time).

@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Jan 17, 2020

How's Set Codewind Server Logging Level as a command name (to make clear i'm not talking about the plugin's logging level)

tetchel added a commit to tetchel/codewind-vscode that referenced this issue Jan 17, 2020
eclipse/codewind#1251

Signed-off-by: Tim Etchells <timetchells@ibm.com>
tetchel added a commit to tetchel/codewind-vscode that referenced this issue Jan 17, 2020
eclipse/codewind#1251

Signed-off-by: Tim Etchells <timetchells@ibm.com>
@johnmcollier

This comment has been minimized.

Copy link
Member Author

@johnmcollier johnmcollier commented Jan 17, 2020

That works for me.

tetchel added a commit to eclipse/codewind-vscode that referenced this issue Jan 17, 2020
eclipse/codewind#1251

Signed-off-by: Tim Etchells <timetchells@ibm.com>

Co-authored-by: John Pitman <jspitman@ca.ibm.com>
@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Jan 17, 2020

done in vscode

@eharris369

This comment has been minimized.

Copy link

@eharris369 eharris369 commented Jan 23, 2020

Done in Eclipse: eclipse/codewind-eclipse#537. You must first enable support features in the Codewind preferences and then the menu item will appear on the connection.

@malincoln

This comment has been minimized.

Copy link

@malincoln malincoln commented Feb 13, 2020

@johnmcollier pls verify and close. Thanks

@sishida sishida added area/docs and removed area/docs labels Feb 14, 2020
sishida added a commit to eclipse/codewind-docs that referenced this issue Feb 24, 2020
PR that touches the following issues:

Developer issue: eclipse/codewind#1251
Doc issue that corresponds to the developer issue: eclipse/codewind#2227
Related doc issue: eclipse/codewind#2141
sishida added a commit to eclipse/codewind-docs that referenced this issue Feb 26, 2020
* [WIP] Setting Codewind server logging levels

PR that touches the following issues:

Developer issue: eclipse/codewind#1251
Doc issue that corresponds to the developer issue: eclipse/codewind#2227
Related doc issue: eclipse/codewind#2141

* Adding feedback from team

* Adding more feedback edits

* Add new section, edit Eclipse point
@sishida

This comment has been minimized.

Copy link
Contributor

@sishida sishida commented Feb 26, 2020

Documentation is complete with this issue (#2227) and this PR (eclipse/codewind-docs#408).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.