Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api for enabling/disabling injection of metrics #1290

Closed
tobespc opened this issue Nov 27, 2019 · 16 comments
Closed

Add api for enabling/disabling injection of metrics #1290

tobespc opened this issue Nov 27, 2019 · 16 comments

Comments

@tobespc
Copy link
Contributor

@tobespc tobespc commented Nov 27, 2019

For 0.7.0 we have the ability to inject monitoring metrics into the application automatically. However, a user may not want this so need to provide the option to enable/disable.

We will add a new api to portal

/api/v1/projects/<id>/metrics/inject with a body of {enable : boolean}

The implementation in pfe of this api will result in the project.inf having the setting updated. A build is also triggered to straight away reflect the change.

IDE's will need changing to add a new checkbox to enable/disable injection
Screenshot 2019-12-02 at 15 50 40

@jopit

This comment has been minimized.

Copy link

@jopit jopit commented Nov 27, 2019

@deboer-tim I'm going to prioritize the ide part of this below the hybrid work unless you say otherwise

@tobespc

This comment has been minimized.

Copy link
Contributor Author

@tobespc tobespc commented Dec 2, 2019

/assign @james-wallis

@jgwest

This comment has been minimized.

Copy link
Member

@jgwest jgwest commented Dec 2, 2019

@tobespc: GitHub didn't allow me to assign the following users: james-wallis

Note that only org members, repo collaborators and people who have commented on this issue/PR can be assigned.

@james-wallis

This comment has been minimized.

Copy link
Contributor

@james-wallis james-wallis commented Dec 2, 2019

/assign

@rwalle61

This comment has been minimized.

@micgibso

This comment has been minimized.

Copy link

@micgibso micgibso commented Dec 4, 2019

Document the enabling/disabling injection of metrics toggle switch (Auto inject metrics) for the Project Status view. Put here for, for example, VS Code http://codewind-docs.rtp.raleigh.ibm.com:4321/codewind/mdt-vsc-commands-project.html. Rework post 0.7.0 under issue #1362.

@rwalle61

This comment has been minimized.

Copy link
Contributor

@rwalle61 rwalle61 commented Dec 5, 2019

/assign

@tobespc

This comment has been minimized.

Copy link
Contributor Author

@tobespc tobespc commented Dec 5, 2019

the work to add the check box to eclipse is still in progress, everything else is done. the eclipse checkbox should land tomorrow (friday)

@james-wallis

This comment has been minimized.

Copy link
Contributor

@james-wallis james-wallis commented Dec 6, 2019

The work for the VSCode and Che plugin landed 2 days ago (Wednesday).

I started work on the Eclipse plugin yesterday and for issue tracking purposes I've split the Eclipse implementation out to issue #1406

@james-wallis

This comment has been minimized.

Copy link
Contributor

@james-wallis james-wallis commented Dec 6, 2019

The work for the Eclipse plugin has now landed.

@micgibso

This comment has been minimized.

Copy link

@micgibso micgibso commented Dec 9, 2019

Docs PR approved and merged: eclipse/codewind-docs#253

@tobespc

This comment has been minimized.

Copy link
Contributor Author

@tobespc tobespc commented Dec 9, 2019

this has now finished and can be closed

@rwalle61

This comment has been minimized.

Copy link
Contributor

@rwalle61 rwalle61 commented Dec 9, 2019

I believe this is done on PFE's end.

@james-wallis can you confirm if the checkbox is done?

Then @micgibso can close this when docs are done

@rwalle61 rwalle61 removed their assignment Dec 9, 2019
@james-wallis

This comment has been minimized.

Copy link
Contributor

@james-wallis james-wallis commented Dec 11, 2019

The checkbox is done for all 3 editors.

@james-wallis james-wallis removed their assignment Dec 11, 2019
@malincoln

This comment has been minimized.

Copy link

@malincoln malincoln commented Dec 13, 2019

I believe this is done on PFE's end.

@james-wallis can you confirm if the checkbox is done?

Then @micgibso can close this when docs are done

@micgibso can you close this one now? Thanks

@micgibso

This comment has been minimized.

Copy link

@micgibso micgibso commented Dec 13, 2019

@malincoln Closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.