Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Inject metrics not available for openliberty project #1509
The 2 stories we want to focus on are
"Developer brings their OpenLiberty (or Java or Node.js) application to codewind and they don't have any type of metrics. We can inject metrics as OpenLiberty is a application with a pom.xml and we support injection for that"
"Developer brings their OpenLiberty (or Java or Node.js) application to codewind and they already have data on a /metrics endpoint (mpmetrics for example). We should display our dashboards plotting as much as possible from that data but.... also allow additional metrics to be injected to fill in any blanks that there data might have"
The simple fix would be to say that if a project is of language Java, we always allow injection and a link to our performance dashboard. If they don't have /metrics and don't choose to inject, then the dashboard will have empty graphs (this is different to previous releases where a 404 would return when no monitoring available).
the short-term fix is to update https://github.com/eclipse/codewind-vscode/blob/master/dev/src/codewind/project/ProjectType.ts#L139 to check against the list of supported languages instead. ie
I think this is 2 user stories/ pieces of functionality, which can be completed independently of each other:
For 1, @tetchel's suggestion enables this in VSCode, then we need to make PFE able to inject into open liberty projects.
For 2, quick fixes include eclipse/codewind-vscode#355 and eclipse/codewind-eclipse#493. These show the
Moving forwards on 2, we should properly (i) check whether they actually have a