Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject metrics not available for openliberty project #1509

Closed
tobespc opened this issue Dec 12, 2019 · 15 comments
Closed

Inject metrics not available for openliberty project #1509

tobespc opened this issue Dec 12, 2019 · 15 comments
Assignees

Comments

@tobespc
Copy link
Contributor

@tobespc tobespc commented Dec 12, 2019

The 2 stories we want to focus on are

"Developer brings their OpenLiberty (or Java or Node.js) application to codewind and they don't have any type of metrics. We can inject metrics as OpenLiberty is a application with a pom.xml and we support injection for that"

"Developer brings their OpenLiberty (or Java or Node.js) application to codewind and they already have data on a /metrics endpoint (mpmetrics for example). We should display our dashboards plotting as much as possible from that data but.... also allow additional metrics to be injected to fill in any blanks that there data might have"

The simple fix would be to say that if a project is of language Java, we always allow injection and a link to our performance dashboard. If they don't have /metrics and don't choose to inject, then the dashboard will have empty graphs (this is different to previous releases where a 404 would return when no monitoring available).

@tetchel

This comment has been minimized.

Copy link
Contributor

@tetchel tetchel commented Dec 12, 2019

the short-term fix is to update https://github.com/eclipse/codewind-vscode/blob/master/dev/src/codewind/project/ProjectType.ts#L139 to check against the list of supported languages instead. ie

return [
    "java", "nodejs", "swift",
].includes(this.language.toLowerCase());
@rwalle61

This comment has been minimized.

Copy link
Contributor

@rwalle61 rwalle61 commented Dec 16, 2019

I think this is 2 user stories/ pieces of functionality, which can be completed independently of each other:

  1. user with open liberty project can inject metrics
  2. user with open liberty project with /metrics endpoint can click open app monitor and see their metrics graphed (on our app monitor dashboard hosted on our performance container)

For 1, @tetchel's suggestion enables this in VSCode, then we need to make PFE able to inject into open liberty projects.

For 2, quick fixes include eclipse/codewind-vscode#355 and eclipse/codewind-eclipse#493. These show the open app monitor button for all java projects, whether they actually have a /metrics endpoint or not.

Moving forwards on 2, we should properly (i) check whether they actually have a /metrics endpoint, and (ii) report this to the IDEs. Perhaps we should rename metricsAvailable to doesProjectHostMetricsDash, and then use a new boolean doesProjectHaveMetricsEndpoint

@rwalle61

This comment has been minimized.

Copy link
Contributor

@rwalle61 rwalle61 commented Dec 16, 2019

Part of part 2: #1544

@rwalle61

This comment has been minimized.

Copy link
Contributor

@rwalle61 rwalle61 commented Dec 16, 2019

Also part of part 2: #1543

@mattcolegate

This comment has been minimized.

Copy link
Contributor

@mattcolegate mattcolegate commented Jan 13, 2020

/assign

@mattcolegate

This comment has been minimized.

Copy link
Contributor

@mattcolegate mattcolegate commented Jan 13, 2020

/in progress

@mattcolegate

This comment has been minimized.

Copy link
Contributor

@mattcolegate mattcolegate commented Jan 13, 2020

/inprogress

@jgwest

This comment has been minimized.

Copy link
Member

@jgwest jgwest commented Jan 13, 2020

/pipeline in progress

@tobespc

This comment has been minimized.

Copy link
Contributor Author

@tobespc tobespc commented Jan 27, 2020

as part of this, need to update our template to be a lot simpler - I can do this

@mattcolegate

This comment has been minimized.

Copy link
Contributor

@mattcolegate mattcolegate commented Jan 31, 2020

Open Liberty Injection now delivered through the three PRs above and can be verified.
/pipeline Verify

@mattcolegate

This comment has been minimized.

Copy link
Contributor

@mattcolegate mattcolegate commented Feb 11, 2020

@tobespc I think this can be closed

@mattcolegate

This comment has been minimized.

Copy link
Contributor

@mattcolegate mattcolegate commented Feb 20, 2020

/pipeline closed

@codewind-bot

This comment has been minimized.

Copy link
Collaborator

@codewind-bot codewind-bot commented Feb 20, 2020

@mattcolegate: Unable to locate pipeline with name: closed

@mattcolegate

This comment has been minimized.

Copy link
Contributor

@mattcolegate mattcolegate commented Feb 20, 2020

@tobespc Please close this.

@tetchel tetchel closed this Feb 20, 2020
@jgwest

This comment has been minimized.

Copy link
Member

@jgwest jgwest commented Feb 20, 2020

@mattcolegate Looks like 'closed' isn't an actual ZenHub pipeline (despite the fact it appears as one in the web UI 🤔 )... you can use /close for this (and in the mean time I will have the bot use /close whenever /pipeline closed is detected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.