Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
New app monitor dashboard to display prometheus metrics of Codewind projects #977
Codewind version: Latest
Description of the enhancement:
Appmetrics-dash and javametrics-dash are cool, but users don't want to have to include that code in their projects. It'd be useful to be able to see these metrics dashboard without the user having to change anything about their Codewind projects.
It'd be good if the IDEs'
So the PFE changes are in: we can inject metrics into nodejs, liberty and spring projects.
The remaining thing is to have the
Whereas I have previously opened PRs in the IDE repos to manage this logic in the IDEs, I think it it makes more sense to have this logic in PFE instead. This allows the IDEs, as frontends, to simply consume information from PFE, where everything is worked out.
More specifically, PFE will calculate the app monitor dashboard url, and provide that information on the
@mattcolegate and I are working on that now
So after we merge that PR, the IDEs will be able to simply ask PFE what the appMonitorUrl is for the project. I've raised a PR for the VSCode plugin to illustrate this - please review (but don't merge until that PR is merged and I have checked that it works for Swift, hopefully all happening tomorrow/wednesday).
Change of plan because it turns out that:
Therefore we have decided to keep the logic in the IDEs. We will extend the existing