Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webdev Support #110

Open
jonas-jonas opened this issue Jul 26, 2019 · 5 comments
Open

Webdev Support #110

jonas-jonas opened this issue Jul 26, 2019 · 5 comments
Assignees
Labels
Projects

Comments

@jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Jul 26, 2019

Dart projects that are supposed to be run in the browser, need to be launched using the webdev CLI tool.
This needs to be supported in the launch configurations.

For this we should somehow detect if the project depends on build_web_compilers. This can either done

  1. by parsing the pubspec.yaml file or
  2. by looking at the output of pub deps -s compact (also relevant for #109)

I'm not sure yet, what would be the better option.

If the detection detects such a project, there should be another Run as entry titled Run as webdev application, which launches the webdev cli in the current project. Also; there are two commands relevant here webdev serve and webdev build. Both should be supported.

@jonas-jonas jonas-jonas changed the title Webdev support Webdev Support Jul 26, 2019
@jonas-jonas jonas-jonas self-assigned this Jul 26, 2019
@jonas-jonas jonas-jonas added this to To do in Backlog via automation Jul 26, 2019
@lak-proddev
Copy link
Contributor

@lak-proddev lak-proddev commented Jul 31, 2019

@jonas-jonas I am interested to work on it. If you are not started yet.

Loading

@jonas-jonas
Copy link
Member Author

@jonas-jonas jonas-jonas commented Jul 31, 2019

Loading

@jonas-jonas
Copy link
Member Author

@jonas-jonas jonas-jonas commented Jul 31, 2019

Also note, that webdev should be invoked using the pub global run command. See the stagehand branch for a how to as it should be the same commands.

Loading

@lak-proddev
Copy link
Contributor

@lak-proddev lak-proddev commented Aug 6, 2019

I think these are the sub-tasks.

  • Detect Webdev support should be enabled for the project.
  • Provide Launch configuration
    • webdev serve support
    • webdev build support

Loading

@jonas-jonas
Copy link
Member Author

@jonas-jonas jonas-jonas commented Aug 7, 2019

Yes, looks good to me. Please use https://github.com/eclipse/dartboard/blob/master/org.eclipse.dartboard/src/org/eclipse/dartboard/util/PubUtil.java when instantiating a new ProcessBuilder so you have the PUB_ENVIRONMENT variable set.

Loading

@jonas-jonas jonas-jonas moved this from To do to In progress in Backlog Sep 30, 2019
@jonas-jonas jonas-jonas moved this from In progress to To do in Backlog Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Backlog
  
To do
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants