Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No masking when time series have different lengths #4238

Closed
Tschigger opened this issue Nov 3, 2017 · 2 comments

Comments

@Tschigger
Copy link

commented Nov 3, 2017

I am talking about this example: https://github.com/deeplearning4j/dl4j-examples/blob/master/dl4j-examples/src/main/java/org/deeplearning4j/examples/recurrent/seqclassification/UCISequenceClassificationExample.java

When deleting two time steps of one .csv file in the features folder, the missing time steps are padded with zeros at the end, both in the feature and labels arrays. This is fine according to https://deeplearning4j.org/usingrnns#data Example 4, last illustration on the page, since the missing two time steps are not used anyway because masking makes them irrelevant, right?

I thought so. But the feature mask is 1s only (there should be two zeros at the end) and the labels mask, because it's a classification example, starts with 0s and ends with [1,1,1] instead of [1,0,0]. So in both masks, the padding area is filled with 1s instead of zeros for the shorter time series.

Using dl4j, datavec, nd4j 0.9.1

@AlexDBlack AlexDBlack self-assigned this Nov 27, 2017

AlexDBlack added a commit that referenced this issue Nov 27, 2017
AlexDBlack added a commit that referenced this issue Nov 29, 2017
@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2017

@AlexDBlack AlexDBlack closed this Nov 29, 2017

@lock

This comment has been minimized.

Copy link

commented Sep 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.