Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROC curves not updated after merge #4442

Closed
QAFabianHuch opened this issue Dec 20, 2017 · 2 comments

Comments

@QAFabianHuch
Copy link

commented Dec 20, 2017

Issue Description

  • expected: after merge of two org.deeplearning4j.eval.ROC evaluations, roc/prc-curves are calculated for merged data
  • actual: curves are not re-calculated if they were already set (e.g. from previous calculation)

This causes evaluation metrics to be incorrect. The auc/auprc is set to null, but as the areas are re-calculated using the old curves, the next call of calculateAUC still returns old area

affects 0.9.1

@AlexDBlack AlexDBlack self-assigned this Dec 20, 2017

AlexDBlack added a commit that referenced this issue Dec 21, 2017
AlexDBlack added a commit that referenced this issue Dec 21, 2017
@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2017

Thanks for reporting this. Reproduced and fixed here: #4443

@lock

This comment has been minimized.

Copy link

commented Sep 23, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.