Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND4J: add ClassPathResource "extract folder, recursively" method #5298

Closed
AlexDBlack opened this issue May 23, 2018 · 5 comments

Comments

@AlexDBlack
Copy link
Contributor

commented May 23, 2018

Thit would simplify many tests - for example, Spark tests.

@AlexDBlack AlexDBlack added the ND4J label May 23, 2018

@AlexDBlack AlexDBlack self-assigned this May 23, 2018

@AlexDBlack

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2018

Added here: #5300

@AlexDBlack AlexDBlack closed this May 23, 2018

@saudet

This comment has been minimized.

Copy link
Member

commented May 23, 2018

That was already in JavaCPP with Loader.extractResource()...

@AlexDBlack

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2018

@saudet Ah, looks pretty similar in how it works. Too late now though :)

@saudet

This comment has been minimized.

Copy link
Member

commented May 24, 2018

Though there is a Loader.cacheResource() as well that extracts in ~/.javacpp/cache by default, but doesn't delete, which saves time the next time we need the same resources.

@lock

This comment has been minimized.

Copy link

commented Sep 22, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.