Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameDiff: Align/improve public interfaces for conv ops #5577

Closed
AlexDBlack opened this issue Jun 13, 2018 · 2 comments · Fixed by #6648

Comments

@AlexDBlack
Copy link
Contributor

commented Jun 13, 2018

Some issues:

  • Same mode is different everywhere:
    • Conv2dConfig has isSameMode
    • Conv3dConfig has isValidMode
    • Pooling3dConfig has ceilingMode
  • Variable name conventions differ:
    • Conv2dConfig: k/s/p/d for kernel/stride/pad/dilation - all lower case
    • Conv3dConfig: k/d/p/dilation - with some upper case
    • Pooling3dConfig: k/s/p/dilation - with some upper case
    • Also - why T for the depth dimension in 3d versions?

A bunch of the SameDiff/DifferentialFunctionFactory methods have arbitrary SDVariable[] inputs, even for single input. And no docs so users don't know the order. Better to use signature like SDvariable input, SDVariable weights, SDVariable bias etc.

@AlexDBlack AlexDBlack added this to the SameDiff Ops and Next Steps milestone Jun 13, 2018

@maxpumperla

This comment has been minimized.

Copy link

commented Jun 19, 2018

@AlexDBlack apart from border modes this has been addressed in #5606

@AlexDBlack AlexDBlack self-assigned this Oct 30, 2018

@AlexDBlack AlexDBlack referenced this issue Oct 30, 2018
AlexDBlack added a commit that referenced this issue Oct 30, 2018
AlexDBlack added a commit that referenced this issue Oct 31, 2018
DL4J Fixes (#6648)
* Fix issue with bn mean/var updates being divided by minibatch

* Final batch norm fixes/tests

* #6635 Add exception when trying to use CSV/LineRecordReader without first initializing it

* #5577 Align SameDiff conv op same mode config names

* #6306 scala version suffix

* #6306 change scala versions script

* #6639 Fix KNN test issue

* #6649 add synchronization to avoid thread safety issues with hdf5 library

* Trigger CI

* Fix for conv3d TF import

* CuDNN fixes + remove outdated testss (mode now supported)

* Fix depthwise conv2d + add gradient check

* RNG seed for potentially flaky test

* Partial fix for spark test failures (broadcasts + multiple spark contexts)
@lock

This comment has been minimized.

Copy link

commented Nov 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.