Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL4J: EmbeddingSequenceLayer: no gradient checks, mask support wrong #5778

Closed
AlexDBlack opened this issue Jul 3, 2018 · 1 comment

Comments

@AlexDBlack
Copy link
Contributor

commented Jul 3, 2018

When using mask arrays with EmbeddingSequenceLayer:

java.lang.IllegalStateException: Mismatched shapes (shape = [3, 4, 6], column vector shape =[3, 6])
	at org.nd4j.linalg.api.ndarray.BaseNDArray.doColumnWise(BaseNDArray.java:2827)
	at org.nd4j.linalg.api.ndarray.BaseNDArray.muliColumnVector(BaseNDArray.java:3314)
	at org.deeplearning4j.nn.layers.feedforward.embedding.EmbeddingSequenceLayer.activate(EmbeddingSequenceLayer.java:158)

Also - I found out that there were no gradient checks for this layer :(

@AlexDBlack AlexDBlack added the Bug label Jul 3, 2018

@AlexDBlack AlexDBlack added this to the DL4J/Arbiter/DataVec Next Steps milestone Jul 3, 2018

@AlexDBlack AlexDBlack changed the title DL4J: SequenceEmbeddingLayer: no gradient checks, mask support wrong DL4J: EmbeddingSequenceLayer: no gradient checks, mask support wrong Jul 3, 2018

@maxpumperla maxpumperla self-assigned this Jul 3, 2018

AlexDBlack added a commit that referenced this issue Jul 3, 2018
DL4J Various Fixes (#5766)
* #5713 Fix incorrectly not used FF arg

* #5687 Add getLearningRate methods

* #5704 Fix bug in RddMiniBatches

* #5297 Fix serialization message spam when loading LONG type buffers

* #5420 Fix issue from class initialization order

* #5356 Add property to disable ND4J logging initialization (mainly for tests)

* #5778 Add EmbeddingSequenceLayer gradient checks, fix mask support

* Fix EmbeddingSequenceLayer (now passes gradient checks) + extra test for masking correctness

* #5777 add ND4J RNG convenience methods
@lock

This comment has been minimized.

Copy link

commented Sep 21, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.