Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deeplearning4j-nlp-korean needs scala version suffix; dependency fix #6306

Closed
AlexDBlack opened this issue Aug 29, 2018 · 1 comment · Fixed by #6648

Comments

@AlexDBlack
Copy link
Contributor

commented Aug 29, 2018

https://github.com/deeplearning4j/deeplearning4j/blob/master/deeplearning4j/deeplearning4j-nlp-parent/deeplearning4j-nlp-korean/pom.xml

A couple of problems here.

  1. The module has scala dependencies, but not scala version suffix. Easy fix.
  2. The scala-requiring artifact doesn't follow usual naming conventions

Note that a simple exclusion of the scala 2.11 for scala 2.10 doesn't work - seems the code (dependent library: com.twitter.penguin:korean-text) actually requires 2.11.
java.lang.NoSuchMethodError: scala.Predef$.ArrowAssoc(Ljava/lang/Object;)Ljava/lang/Object

Unfortunately, the dependency doesn't follow usual scala naming conventions:
Scala 2.11:

<dependency>
  <groupId>com.twitter.penguin</groupId>
  <artifactId>korean-text</artifactId>
  <version>4.4.4</version>
</dependency>

Scala 2.10

<dependency>
  <groupId>com.twitter.penguin</groupId>
  <artifactId>korean-text-scala-2.10</artifactId>
  <version>4.2.0</version>
</dependency>

Note also there's a 4.2 of the 2.11 dependency, but no 4.2.0 :/

Anyway, thoughts on a fix here?
First thought was maven profile, check if scala version is 2.10 vs. 2.11, and add the right dependency.
But seems like that's not possible (can use system properties and properties from settings.xml - but not maven properties - to activate profiles).

Only other idea I have is some ugly hacks for our change scala versions script...

@AlexDBlack AlexDBlack self-assigned this Oct 30, 2018

AlexDBlack added a commit that referenced this issue Oct 30, 2018
AlexDBlack added a commit that referenced this issue Oct 30, 2018
@AlexDBlack AlexDBlack referenced this issue Oct 31, 2018
AlexDBlack added a commit that referenced this issue Oct 31, 2018
AlexDBlack added a commit that referenced this issue Oct 31, 2018
AlexDBlack added a commit that referenced this issue Oct 31, 2018
DL4J Fixes (#6648)
* Fix issue with bn mean/var updates being divided by minibatch

* Final batch norm fixes/tests

* #6635 Add exception when trying to use CSV/LineRecordReader without first initializing it

* #5577 Align SameDiff conv op same mode config names

* #6306 scala version suffix

* #6306 change scala versions script

* #6639 Fix KNN test issue

* #6649 add synchronization to avoid thread safety issues with hdf5 library

* Trigger CI

* Fix for conv3d TF import

* CuDNN fixes + remove outdated testss (mode now supported)

* Fix depthwise conv2d + add gradient check

* RNG seed for potentially flaky test

* Partial fix for spark test failures (broadcasts + multiple spark contexts)
@lock

This comment has been minimized.

Copy link

commented Nov 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.