Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND4j: transposei is not inplace #6401

Closed
Xfel opened this issue Sep 8, 2018 · 3 comments

Comments

@Xfel
Copy link

commented Sep 8, 2018

This is documented in NDArrayBase, but very counterintuitive.

The transpose method is implemented using permute, and the inplace variant permutei seems to be working just fine.

@raver119

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2018

Hm, i vaguelly recall there was a reason for that but can't recally why. In c++ we definitely have inplace transpose permit.

So we should update java too. But that'll require check of existing usage of this method

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2018

It was in-place at one point.
Looks like switching from permute to permutei (and copying current permutei to permute op) seems like it would work - i.e., I'm not seeing a reason why we can't have in-place transpose if we have in-place permute.

AlexDBlack added a commit that referenced this issue Sep 17, 2018
AlexDBlack added a commit that referenced this issue Sep 18, 2018
Various fixes (#6450)
* #6401 transposei fix

* #6378 MmulTranspose fix + cleanup

* #6442 validate array order

* Cleanup and test fixes

* #6403 batch norm validation

* #6389 Fix TransferLearning nOutReplace issues; add nInReplace method

* Trigger CI
@lock

This comment has been minimized.

Copy link

commented Oct 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Oct 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.